Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--valid-metrics-stop-on [first|all|any] #850

Closed
emjotde opened this issue Apr 9, 2021 · 2 comments
Closed

--valid-metrics-stop-on [first|all|any] #850

emjotde opened this issue Apr 9, 2021 · 2 comments
Assignees

Comments

@emjotde
Copy link
Member

emjotde commented Apr 9, 2021

Feature description

Add an option --valid-metrics-stop-on [first|all|any] that defines together with --early-stopping N and --valid-metrics metric1 ... metricN if early stopping should take into account only first, all, or any metrics.

  • first: current default behaivor, stop if first metric stalled N times
  • all: stop if all of the metrics have currently stalled N or more times (if the minimum of all stalled counts is N)
  • any: stop if any of the listed metric has stalled N times (if the maximum of all stalled counts is N).

Example

  • --valid-metrics perplexity chrf bleu --early-stopping 10 --valid-metrics-stop-on all: training stops if chrf stalled 10 times, perplexity 15 times and bleu 11 times, but not if e.g. perplexity stalled only 9 times with rest as described.
@emjotde
Copy link
Member Author

emjotde commented Apr 9, 2021

Maybe we want more complicated pattern like --valid-metrics-stop-on 0 1 any which ignores the third metric? But maybe that's overkill.

emjotde pushed a commit that referenced this issue May 24, 2021
Adds `--early-stopping-on first|all|any` allowing to decide if early stopping should take into account only first, all, or any validation metrics.

Feature request: #850
Regression tests: marian-nmt/marian-regression-tests#79
@snukky
Copy link
Member

snukky commented Jan 27, 2022

It's been implemented. Closing.

@snukky snukky closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants