Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for adding new validation metrics with --valid-reset-stalled #80

Closed
wants to merge 1 commit into from

Conversation

snukky
Copy link
Member

@snukky snukky commented Apr 29, 2021

Note this is added on top of romang/early-stopping-on.

emjotde pushed a commit to marian-nmt/marian-dev that referenced this pull request Jul 9, 2021
…-stalled

This fixes a bug that's been discovered recently by checking if a validator exists before resetting its stalled validations.
Regression test for it is in: marian-nmt/marian-regression-tests#80
@snukky
Copy link
Member Author

snukky commented Jul 26, 2021

Merged together with #79.

@snukky snukky closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant