Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-13: HasResultStatusCheckShortSyntax plugin #19

Merged
merged 11 commits into from
Nov 21, 2022

Conversation

Olha-30
Copy link
Contributor

@Olha-30 Olha-30 commented Nov 13, 2022

What was done as a part of this PR?

  • Implemented the HasResultStatusCheckShortSyntax plugin.
  • Added specs for the HasResultStatusCheckShortSyntax plugin.

Why it was done?

  • To have the ability to call success?, error?, failure? etc, without calling result.

    Before(a way to check the service status)

    Service.result(**kwargs).success?

    After(one more way to check the service status)

    Service.success?(**kwargs)

How to test?

  • Use the following command:
    task rspec -- spec/lib/convenient_service/service/plugins/has_result_status_check_short_syntax

Checklist:

  • I have performed a self-review of my code.
  • I have added/adjusted tests that prove my fix is effective or that my feature works.
  • CI is green.

@Olha-30 Olha-30 self-assigned this Nov 13, 2022
@Olha-30 Olha-30 changed the title CS-12: HasResultStatusCheckShortSyntax plugin CS-13: HasResultStatusCheckShortSyntax plugin Nov 13, 2022
@coveralls
Copy link

coveralls commented Nov 13, 2022

Pull Request Test Coverage Report for Build 3457344558

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 22 (72.73%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 95.811%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/convenient_service/service/plugins/has_result_status_check_short_syntax/concern.rb 13 19 68.42%
Totals Coverage Status
Change from base Build 3456897160: -0.09%
Covered Lines: 5352
Relevant Lines: 5586

💛 - Coveralls

Copy link
Owner

@marian13 marian13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Olha-30

Please, resolve the comments above, then we are good to merge 🎉🎉🎉

@marian13 marian13 added the feature Feature was the initial reason of the PR. From Conventional Commits. label Nov 20, 2022
@Olha-30 Olha-30 merged commit 04352a8 into main Nov 21, 2022
@marian13 marian13 deleted the CS-13_has_result_status_check_short_syntax branch November 21, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature was the initial reason of the PR. From Conventional Commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants