Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ticket #19

Merged
merged 13 commits into from
Feb 24, 2023
Merged

support ticket #19

merged 13 commits into from
Feb 24, 2023

Conversation

rueshyna
Copy link
Collaborator

@rueshyna rueshyna commented Feb 23, 2023 •
edited
Loading

  • support ticket
    • the type of Execute lambda of proposal is changed
    • add new entrypoint to receive ticket
  • remove Execute proposal

@rueshyna rueshyna linked an issue Feb 23, 2023 that may be closed by this pull request
sunset Execute of ('a transaction) #12
Closed
tj825
tj825 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@tj825 tj825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is silly, there is no use case and we can't support it in any reasonable way in the UI. But it looks OK to me.

src/internal/execution.mligo Outdated
match Tezos.join_tickets (t, s) with
| None -> failwith Errors.cannot_happen
| Some new_t -> Big_map.add (content, addr) new_t tickets
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated by Storage.store_ticket. Too many files 😉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good eyes, I removed it.

src/internal/proposal_content.mligo Show resolved Hide resolved
@rueshyna rueshyna mentioned this pull request Feb 24, 2023
Open
@rueshyna
Copy link
Collaborator Author

rueshyna commented Feb 24, 2023 •
edited
Loading

I think this is silly, there is no use case and we can't support it in any reasonable way in the UI. But it looks OK to me.

As discussion off-line, we support simple case use in UI for now.

@rueshyna rueshyna merged commit 8dfce4d into main Feb 24, 2023
@rueshyna rueshyna deleted the cc@support_ticket branch May 18, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tj825 tj825 tj825 approved these changes

@JulesGuesnon JulesGuesnon Awaiting requested review from JulesGuesnon

@pkhry pkhry Awaiting requested review from pkhry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sunset Execute of ('a transaction)
2 participants
@rueshyna @tj825