Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide: How to write components #85

Closed
sebald opened this issue Mar 9, 2020 · 0 comments · Fixed by #97
Closed

Guide: How to write components #85

sebald opened this issue Mar 9, 2020 · 0 comments · Fixed by #97
Assignees
@viktoria-schwarz
Labels
type:docs Improvements or additions to documentation
Milestone
⍺-lpha

Comments

@sebald
Copy link
Member

sebald commented Mar 9, 2020

We should establish some minimal guidelines before going into writing actual components.

Here are some ideas:

API

  • We should expose the spacing style props
  • We should expose the as prop
  • We should expose the variant prop

Misc

  • We should have a11y in mind and support some level of ARIA Standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktoria-schwarz viktoria-schwarz

Labels
type:docs Improvements or additions to documentation
Projects
None yet
Milestone
⍺-lpha
Development

Successfully merging a pull request may close this issue.

docs: how to write components marigold-ui/marigold
3 participants
@sebald @viktoria-schwarz @ti10le