Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: how to write components #97

Merged
merged 1 commit into from
Mar 20, 2020
Merged

docs: how to write components #97

merged 1 commit into from
Mar 20, 2020

Conversation

viktoria-schwarz
Copy link
Contributor

closes #85

sebald
sebald requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@sebald sebald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the style props 😜

sebald
sebald requested changes Mar 15, 2020
View reviewed changes
Copy link
Member

@sebald sebald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rename the story because of

packages/system/src/stories.mdx Outdated Show resolved Hide resolved
packages/system/src/stories.mdx Outdated Show resolved Hide resolved
@sebald sebald mentioned this pull request Mar 15, 2020
Merged
@coveralls
Copy link

coveralls commented Mar 17, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 90.909% when pulling cc3b0f6 on how_to_write_components into c7b1f2f on master.

@viktoria-schwarz viktoria-schwarz changed the title WIP docs: how to write components docs: how to write components Mar 17, 2020
ti10le
ti10le previously approved these changes Mar 18, 2020
View reviewed changes
packages/system/src/write-component.stories.mdx Outdated Show resolved Hide resolved
@sebald sebald merged commit 040a497 into master Mar 20, 2020
@sebald sebald deleted the how_to_write_components branch March 20, 2020 12:43
@Toshibot Toshibot mentioned this pull request Mar 26, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebald sebald sebald approved these changes

@ti10le ti10le ti10le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guide: How to write components
4 participants
@viktoria-schwarz @coveralls @sebald @ti10le