Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typo check to make py-test 😢 #1316

Closed
dmadisetti opened this issue May 4, 2024 · 2 comments · Fixed by #1318
Closed

Add typo check to make py-test 😢 #1316

dmadisetti opened this issue May 4, 2024 · 2 comments · Fixed by #1318

Comments

@dmadisetti
Copy link
Collaborator

Description

I guess I can't spell and I keep triggering it

Suggested solution

Just another make rule

Alternative

I learn to spell!

Additional context

No response

@mscolnick
Copy link
Contributor

mscolnick commented May 4, 2024

I would like to actually add pre-commit, that is optional and only contains fast check.

I have opinions for a FE only project, but not sure what a good setup looks like for Python.

@akshayka
Copy link
Contributor

akshayka commented May 5, 2024

This is typically what's used to configure pre-commit for Python projects: https://pre-commit.com/index.html

An optional pre-commit with fast checks sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants