Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download as button is not responsive #1577

Closed
akshayka opened this issue Jun 7, 2024 · 3 comments · Fixed by #1845
Closed

Download as button is not responsive #1577

akshayka opened this issue Jun 7, 2024 · 3 comments · Fixed by #1845
Assignees
Labels
bug Something isn't working good first issue (typescript) Good first issue on the frontend/typescript good first issue Good for newcomers

Comments

@akshayka
Copy link
Contributor

akshayka commented Jun 7, 2024

Hey, big fan of marimo here. I was trying to use WASM to embed it in a website I'm developing. I see this new button isn't quite responsive. Are you planning on making it not visible as a config or put it in the end of the notebook or maybe a bit above?

image

Originally posted by @jevalentini in #1469 (comment)

@akshayka akshayka added bug Something isn't working good first issue Good for newcomers good first issue (typescript) Good first issue on the frontend/typescript labels Jun 7, 2024
@MadGanGithub
Copy link

Hi @akshayka @scls19fr @tlpinney @ideoforms @dbrans ,
I'd like to work on this issue. Could you please assign it to me?

@mscolnick
Copy link
Contributor

@MadGanGithub, awesome! i assigned it to you. let me know if you need any help getting setting up - we can chat in discord.

as far as implementation, i was thinking we could have a smaller button (maybe triple dots and minimal with no background).
for responsiveness you can use tailwind's responsive classname utilities (https://tailwindcss.com/docs/responsive-design) to hide and show each button depending on screensize

@mscolnick
Copy link
Contributor

@MadGanGithub, I took this over and snuck the fix in this PR #1845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue (typescript) Good first issue on the frontend/typescript good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants