Fixed bug in distances.py when calculating pairs from arbitrary indices #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I've added some test cases for this to the unit tests and your fix did solve the problem. |
|
Cool! Thanks again for the great library, Richard On 23 January 2015 at 00:21, Mario Mulansky notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mario,
I was using PySpike to calculate the SPIKE distance for 9 groups of 100 neurons, with indices 0-899. I think there was a problem when calculating the SPIKE distance when not starting from index 0 with the original implementation, which should be fixed here. It works on my data but I haven't tested it extensively.
Cheers!
Richard