Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 #263

Merged
merged 9 commits into from
Aug 23, 2016
Merged

2.0.0 #263

merged 9 commits into from
Aug 23, 2016

Conversation

ahumphreys87
Copy link
Member

Moved Backbone and underscore to peerDependencies and bumper semver range.

@@ -52,6 +52,7 @@
"babel-preset-es2015": "^6.3.13",
"babel-preset-es2015-rollup": "^1.1.1",
"babel-register": "^6.3.13",
"backbone": ">=1.3.3 <1.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better just use 1.3.3 as we did it for Mn. Bb are not using semver. So 1.3.5 might have major changes or it's not critical for Radio?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not really critical for radio, it uses a subset of backbones features

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 then)

@paulfalgout
Copy link
Member

👍

1 similar comment
@denar90
Copy link
Member

denar90 commented Aug 23, 2016

👍

@ahumphreys87 ahumphreys87 merged commit 8d3c7de into master Aug 23, 2016
@ahumphreys87 ahumphreys87 deleted the major branch August 23, 2016 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants