Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Adapt to New Stock Page Header DOM Structure #200

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thirumalairajr
Copy link

This pull request addresses the issue where the get_stock() function is failing due to a change in the DOM structure of the stock page header on the Finviz website. To resolve this problem, I have implemented a hotfix that adjusts the crawler's code to accommodate the updated header structure. This ensures the continued functionality of the Finviz crawler for retrieving stock data.

@thirumalairajr
Copy link
Author

@d3an can you please review this PR ?

@sw8989
Copy link

sw8989 commented Oct 14, 2023

Works now, thanks for the quick fix !

@Rinkels
Copy link

Rinkels commented Oct 16, 2023

Works 100%. Thanks for the quick fix!

Mahanya Kochhar and others added 2 commits October 19, 2023 00:57
@lmk3087
Copy link

lmk3087 commented Nov 14, 2023

I'm not sure if this is relevant but just wanted to comment my findings.

The fix in main_func.py did work, almost fully. I ran over 330 stock I was interest in. 329 succeeded. 1 failed. BMO. I am not seeing anything overly unique about this stock. Maybe it would have failed previously as well - I don't know.

It is Bank of Montreal, and it is missing an index on finviz. I don't know if this matters, but I wanted to share just in case it was.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants