Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the build publishable #14

Closed
wants to merge 3 commits into from
Closed

Conversation

knshiro
Copy link
Contributor

@knshiro knshiro commented Feb 5, 2016

Hi,

This should fix #11.

I switched your build tool to gradle (http://gradle.org/) and made your library publishable on bintray (https://bintray.com/) thanks to gradle-bintray-plugin (https://github.com/bintray/gradle-bintray-plugin).

You just need to add in ~/.gradle/gradle.properties

bintrayUser = user
bintrayApiKey = your-bintray-api-key   // Not password!!

Or use environment varialbles (for example if you want to deploy from travis)

export BINTRAY_USER=user
export BINTRAY_API_KEY=your-bintray-api-key

Then use:

./gradlew bintrayUpload

The build launches your tests without the "test_with_php" system properties but you can also activate it by using the environment variable:

export TEST_WITH_PHP=yes

@knshiro
Copy link
Contributor Author

knshiro commented Feb 5, 2016

About the failed build, I checked it's only a memory error. It should pass if you rerun it.
It just worked on our travis: https://travis-ci.org/en-japan/kanatools-java/builds/107164321

@mariten
Copy link
Owner

mariten commented Feb 6, 2016

Hi @knshiro
Thanks for the first pull request! Let me look this over and play around locally with gradle (I haven't used it personally but have heard good things about it) so I get a good grasp on what has changed.

The failing on Travis CI is a problem though. I saw it works on your en-japan one, but it has to work on the normal one as well -- I'll experiment with this.

@mariten
Copy link
Owner

mariten commented Feb 6, 2016

@knshiro Actually would you mind remaking this pull request and directing it to staging, not master?
That way:

  1. Can see if it succeeds on Travis CI again before putting in master (aka, releasing it)
  2. If merged, I will need to update the documentation prior to release.

Thanks again for fixing this up, and really appreciate you kept in the JUnit test running and Jacoco coverage process

@knshiro
Copy link
Contributor Author

knshiro commented Feb 6, 2016

@mariten Ok sure I'm closing this PR and reopening another on staging

@knshiro knshiro closed this Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish to Maven Central
2 participants