Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for the refresh rate to be specified #16

Conversation

philipbelesky
Copy link
Collaborator

Hey, thanks for all the recent updates! I'm not myself sold on whether this is a good idea (and am mindful of settings overload) but there were a couple of times when I wanted to be able to control the interval between the solution expiring. These were:

  • When I first started trying out the new version I had disabled the discrete GPU (long story; trying to get an external GPU running) and as a result found the performance of GH very slow. The default 20ms interval would (somewhat) slowly update in Rhino, but the definition itself was basically un-interactive. With the main GPU running again everything was fine. But it may be worth allowing users to specify a longer interval if they are running with truly bad hardware
  • Related to the above: adding downstream components that do relatively heavy computations seems to essentially add latency to interacting with the definition
  • When developing a definition it can be nice to have a 'manual update' mode where the mesh only updates on a forced recalculation of the definition (the slight jumping/shifting of the geometry can be distracting)

Copy link
Owner

@mariuszhermansdorfer mariuszhermansdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it it for now. This setting should be later offloaded from the main component and clustered in external SandWorm options to prevent visual clutter

@mariuszhermansdorfer mariuszhermansdorfer merged commit c0b8d2f into mariuszhermansdorfer:master Sep 4, 2019
@mariuszhermansdorfer
Copy link
Owner

The more robust approach would be to spawn the computation on a separate thread, so that it doesn't lock the UI thread. Opened #18

@philipbelesky philipbelesky deleted the feature/tick-rate branch September 5, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants