Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This all seemed simple enough in terms of code implementation, although there is a slightly strange behavior where the setting seems to 'persist' in the output mesh. If the toggle is set before the definition is executed, the resulting mesh will either be colored or 'bare' as expected. However, changing the setting subsequently will not then change the result despite the fact the correct code path is being executed for the toggle. Is there some behavior, or interaction with the scheduler, which would explain why the output mesh 'remembers' its previous vertex colors? As far as I can tell, the lookup table definitely isn't being employed.
The change in behavior in
Core.vs
and the component file is pretty straightforward now given the only options are basically on/off. If additional color options are added it would probably benefit from a better abstraction to map between the set option and, the calculations needed to identify vertex colors.Anyway, let me know if you think the context menu approach is useful, or if #20 should be abandoned in favour of dedicated components / a standard parameter / something else.