-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'neutral' cut and fill colour so contours/labels will show #86
Change 'neutral' cut and fill colour so contours/labels will show #86
Conversation
cfdd7bd
to
a6ec68c
Compare
Sorry for the pushing/closing/opening - accidentally included a few stray commits. Also, looking at this again, having a dark gray isn't a great option as the red-ish gray and green-ish gray look similarly muddy. Perhaps a blue would work? Or, alternately, the original white but with the labels/contours as black? |
I see your point. On the other hand, I liked using dark grey to 'mask out' the irrelevant part of the mesh and only focus on the area of interest. White on white was a similar attempt of visually conveying the message, that this portion is done already and you can shift your attention elsewhere. Essentially - there is only work to be done, where labels are still visible. The remaining parts, don't require user's attention any more. Having said that, I can see, why it can be quite confusing. Perhaps your last suggestion to switch label color to black while working with the |
Yea, I think the white-on-white fading is pretty intuitive. Another option might be just to hide labels that are at 0? The key problem is probably the contour display as that information (if desired) is meaningfully limited by the white-on-white display. In other modes, it's probably idea to keep those white as I think they show up better when using a projector. Perhaps as a slight compromise/stop-gap, an "Invert label/contour colors" checkbox could be added that switches between white/black? That's probably just enough control to allow for workarounds and could be desirable even if using standard analysis modes with custom colors. If that sounds good, let me know and I can update this PR to add it in. |
Good idea, @philipbelesky. Instead of a simple checkbox, maybe we could have a slider which transitions labels' colors from white to black? We would then give users the options to work with various shades of grey rather than just a binary choice of two colors. |
9e23eed
to
ad60a53
Compare
Hey, just getting back into a few Sandworm things. I've updated this PR to the latest from the 2.0 branch and implemented the slider as suggested: 2022-01-24.16-22-29.mp4Let me know if it needs anything else! |
7d0a119
into
mariuszhermansdorfer:feature/SandWorm2-0
Suggestion: as both the labels and contours are white (and themes developed around this?) they get lost in the cut/fill mode where a large portion of the model might be in the 'neutral' state - particularly if you're only position a few items in it rather than a 1:1 copy of the mesh with the same bounds. Shifting that colour to black might be more usable?