Ported mark2 to Python 3 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some of the most common issues with mark2 to the readme and their solutions.
Changed properties to be an OrderedDict so options are applied in order. This allows you to list your JVM arguments in order and if one depends on another, you can just place it before it in your mark2.properties file
Fixed an issue with the test case for the process service where strings were passed instead of bytes causing an error.
|
Note: The install guide will need to be updated. I can update the ubuntu one with certainty but others will need to pitch in for the other distros to confirm the process works |
|
@gsand any chance you have some other way I could contact you to discuss this? Would be nice for this to be considered |
See https://onlinegdb.com/2lPg2_aFx for demonstration
Made the unknown command regex more generic to hopefully catch a wider range of messages (I.E. spigot msg, vanilla msg and older MC versions.
|
Hi, I’ve added you as a collaborator. Mark2 needed collaborators. Thank you for updating to python3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some painstaking work and well over 12-16 hours of debugging, I have (finally) completed a port of mark2 to python 3! Please note: This includes changes to the readme I submitted in my last PR: #127 which will be closed as of posting.
I tested as much of the functionality as I could (it even passes the self-tests apart from the
.parse_timeones that I'm pretty sure are just due to other changes in the code base over the years).What I could not test is the integrations (IRC, Mumble etc.) as I don't have the infrastructure set up to test that.
I am willing and able to maintain mark2 post update and fix any bugs this port reveals.
I do recommend making a new branch on the repository for this port as I would consider this a test more than a polished port due to the above lack of testing for the integrations.