avoid pessimistic busy render loop #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that running `sp` would spin 100% cpu for both `sp` and my terminal emulator. I ran this down to this bit of code, which would force a full screen render every 100ms. What seems to work for me is making this only return a Refresh action if there is a pending refresh.
|
To reproduce this, run |
|
Thanks! |
wez
added a commit
to wez/streampager
that referenced
this pull request
Jun 3, 2019
forgot to do this as part of markbt#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that running
sp < README.mdwould spin 100% cpu for bothspand my terminal emulator. I ran this down to this bit of code,
which would force a full screen render every 100ms.
What seems to work for me is making this only return a Refresh
action if there is a pending refresh.