Add repeatation support like 100j, 4 ^D, 20g, etc #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbt
requested changes
Jun 28, 2021
There was a problem hiding this comment.
Weirdly this is one of the less features that used to annoy me, as I'd often end up in weird modal states by accidentally hitting numbers. But the way it's implemented here seems much more usable. I think Esc clearing the pending numbers makes it much nicer.
This does reveal some places where I should've used saturating arithmetic, but didn't (e.g. src/screen.rs:858), as it's now feasible for users to scroll usize::MAX positions to the right. We probably need to fix those (but you don't have to do that right now).
quark-zju
force-pushed
the
repeat
branch
2 times, most recently
from
c2edafd
to
5d03912
Compare
Basic support something like 10j, 30k, etc.
Make things like 100G, or 100g behave like less or vim - go to line 100.
They are too verbose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing feature existed in less / vim.