-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update object-assign to 4.0 #7
Conversation
Current coverage is 100% (diff: 100%)@@ master #7 diff @@
=====================================
Files 1 1
Lines 18 18
Methods 4 4
Messages 0 0
Branches 6 6
=====================================
Hits 18 18
Misses 0 0
Partials 0 0
|
It would be great to merge this ! |
Considering support for ES6 It's not a big deal either way, but right now with the outdated dependency it makes it more tempting than it should be to inline the code. |
Any progress on this? Slightly annoying warning on my project:
|
Same issue as @sidoruk-sv. Would love to see this merged |
Same issue as @sidoruk-sv. |
Hi @markdalgleish , just checking in. It would be great, if you could merge this PR. The old object-assign version is causing troubles in some of my projects. |
ping |
4.0 improved the performance a lot, and the ordering might change a bit, but by looking at the code, I think the order is not important for react-themable.
https://github.com/sindresorhus/object-assign/releases
@markdalgleish