Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object-assign to 4.0 #7

Closed
wants to merge 1 commit into from
Closed

Update object-assign to 4.0 #7

wants to merge 1 commit into from

Conversation

danez
Copy link

@danez danez commented Dec 13, 2016

4.0 improved the performance a lot, and the ordering might change a bit, but by looking at the code, I think the order is not important for react-themable.

https://github.com/sindresorhus/object-assign/releases

@markdalgleish

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #7 into master will not change coverage

@@             master    #7   diff @@
=====================================
  Files             1     1          
  Lines            18    18          
  Methods           4     4          
  Messages          0     0          
  Branches          6     6          
=====================================
  Hits             18    18          
  Misses            0     0          
  Partials          0     0          

Powered by Codecov. Last update 0f15ce5...9c1ca9a

@theobat
Copy link

theobat commented Mar 8, 2017

It would be great to merge this !

@thibaudcolas
Copy link

Considering support for ES6 Object.assign is quite good (everything except Node v4 and below, IE11 and below), I'd even suggest dropping that dependency and instead simply mention in the README that people who want to support IE will need to polyfill.

It's not a big deal either way, but right now with the outdated dependency it makes it more tempting than it should be to inline the code.

@sidoruk-sv
Copy link

sidoruk-sv commented Mar 13, 2018

Any progress on this?

Slightly annoying warning on my project:

Multiple versions of object-assign found:
4.1.1 ./~/object-assign
3.0.0 ./~/react-themeable/~/object-assign

@JoshuaRogan
Copy link

Same issue as @sidoruk-sv. Would love to see this merged

@wdh2100
Copy link

wdh2100 commented Dec 26, 2019

Same issue as @sidoruk-sv.

@HenningThiemann
Copy link

Hi @markdalgleish ,

just checking in. It would be great, if you could merge this PR. The old object-assign version is causing troubles in some of my projects.

@sidoruk-sv
Copy link

ping

@danez danez closed this Dec 8, 2022
@danez danez deleted the patch-1 branch December 8, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants