Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Allow this repo to be a pre-commit hook #35

Conversation

fernandahf
Copy link
Contributor

With these changes, this repo will be used as a hook in pre-commit.

@fernandahf fernandahf force-pushed the master-make-this-repo-pre-commit-hook-fer branch 3 times, most recently from 4a285cb to 0760547 Compare December 19, 2022 21:23
@fernandahf
Copy link
Contributor Author

For record:

The tests worked fine!

Screenshot 2022-12-19 at 15 42 54

Screenshot 2022-12-19 at 15 43 11

cc @moylop260

@fernandahf
Copy link
Contributor Author

@markdrago

Could you take a look at this, please?

Those little changes allow using this repo as the hook of https://github.com/pre-commit/pre-commit

More info:

https://pre-commit.com/#new-hooks

@moylop260
Copy link

@markdrago

What do you think?

README.md Outdated
@@ -64,6 +64,17 @@ Additionally PgSanity will read SQL from stdin if it is not given any parameters
$ echo $?
0

# # pre-commit
Copy link
Owner

@markdrago markdrago Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the markdown syntax here: "# #" -> "##". Also please move the "## pre-commit" section to be below the "## interpreting the results" section. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markdrago

Fixed. Thanks!

@fernandahf fernandahf force-pushed the master-make-this-repo-pre-commit-hook-fer branch from 0760547 to a20fdb9 Compare January 2, 2023 23:20
@fernandahf fernandahf force-pushed the master-make-this-repo-pre-commit-hook-fer branch from a20fdb9 to 84c09d6 Compare January 4, 2023 19:11
@markdrago markdrago merged commit 5fb3ce7 into markdrago:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants