-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Em less than 3 chars #1181
Em less than 3 chars #1181
Conversation
/cc @Feder1co5oave and @davisjam to make sure I didn't introduce any security issues |
Lgtm |
I added some edge cases like:
This required adding more capturing parentheses so we could run into another problem like #1013 (comment) |
@joshbruce do we want to risk a breaking change like #1059 or wait for this fix til 0.4.x? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changed regexes are safe from REDOS
Did you disable CI? |
CI is running for other PRs, but I don't see this one: https://travis-ci.org/markedjs/marked/pull_requests |
That's weird, I swear it was there initially. I just rebased and it looks like it came back. |
I'm looking forward to the next release included this fix:laughing: |
@re-fort Definitely! We are waiting for a couple more fixes to land before we release version 0.4.0. |
Em less than 3 chars
Marked version: 8489411
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.