Eslint all the things #1185
Merged
Eslint all the things #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought we decided to ignore test. No skin in this game for me, just making sure not missing some rationale. |
|
no, |
styfle
reviewed
Apr 2, 2018
bin/marked
Outdated
| .on('error', function(err) { | ||
| fs.readFile(__dirname + '/../man/marked.1.txt', 'utf8', function(err, data) { | ||
| spawn('man', [path.resolve(__dirname, '/../man/marked.1')], options) | ||
| .on('error', function(err) { // eslint-disable-line handle-callback-err |
There was a problem hiding this comment.
Should this err be removed since it is unused rather than disabled eslint here?
styfle
approved these changes
Apr 2, 2018
joshbruce
approved these changes
Apr 4, 2018
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
This was referenced Mar 24, 2020
This was referenced Mar 31, 2020
This was referenced Apr 7, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
Eslint all the things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 8489411
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.