-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Flavored Markdown test bed #1210
Conversation
@UziTech: Would also like to start shifting to the separate folders concept but don't know where to begin; think it's just easier to ask and learn or if you would be willing to take it on. With these additional tests we should have a more trustworthy test bed overall...specifically one that protects itself against regression. Would like to get #1135 using it before merging that in, unless you or @styfle think there's a good reason not to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
where are you getting the examples for github_flavored_markdown.json? |
@UziTech: That one I had to build, unfortunately. https://github.github.com/gfm/ - I went to each of the TOC links that said "extension" - and copied and pasted (and modified for new lines - didn't see any tabs or anything weird). |
Here's the plain text version: https://github.github.com/gfm/spec.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put this in a /test/specs/gfm
folder like:
this will follow the update to the cm tests in #1213
Think I got it. A couple of questions for my own edification.
|
|
GitHub Flavored Markdown test bed
Marked version: 0.3.19
Markdown flavor: GitHub Flavored Markdown
Description
Adds GitHub Flavored Markdown to test bed.
It is our understanding that GFM is basically just CommonMark with some extensions. Therefore, this only adds the extensions to the overarching test suite.
Contributor
Committer
In most cases, this should be a different person than the contributor.