Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Practical Redux Part 4 - WIP commits #1

Closed
wants to merge 23 commits into from
Closed

Practical Redux Part 4 - WIP commits #1

wants to merge 23 commits into from

Commits on Nov 15, 2016

  1. Add Semantic-UI-React and Semantic-UI-CSS

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    85e8497 View commit details
    Browse the repository at this point in the history

  2. Disable Webstorm linting for now

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    732be2f View commit details
    Browse the repository at this point in the history

  3. Render an initial SUI component

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    eacee74 View commit details
    Browse the repository at this point in the history

  4. Render initial tabs

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    ecb83d6 View commit details
    Browse the repository at this point in the history

  5. Create a TabBar component to render a list of tabs

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    1e46a11 View commit details
    Browse the repository at this point in the history

  6. Render the list of tabs using the TabBar

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    a88458c View commit details
    Browse the repository at this point in the history

  7. Add react-toggle-display

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    141a50c View commit details
    Browse the repository at this point in the history

  8. Add ability to show a content component for each tab 

    Updated App CSS to only center header, instead of everything.  This
keeps the tab contents from centering as well.
    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    77d74de View commit details
    Browse the repository at this point in the history

  9. Add initial dummy tab panel components

    @markerikson
    markerikson committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    8ef98cb View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2016

  1. Delete unused files

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    a1ab437 View commit details
    Browse the repository at this point in the history

  2. Extract tab panels into separate feature folders

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    7172e1b View commit details
    Browse the repository at this point in the history

  3. Set page title

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    6372664 View commit details
    Browse the repository at this point in the history

  4. Add initial form layout for UnitInfo

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    fb2f7cc View commit details
    Browse the repository at this point in the history

  5. Enable absolute import paths (such as "features/a/SomeComponent") 

    There's been numerous requests for Create-React-App to support having
imports resolved relative to the "src" folder.  The semi-documented
solution is to have a NODE_PATH environment variable, which will be
used in the resolution process.  It's apparently also possible to
specify that variable in a file named ".env".

References:

facebook/create-react-app#476
facebook/create-react-app#693
facebook/create-react-app#741
    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    eecf3a2 View commit details
    Browse the repository at this point in the history

  6. Use absolute imports in App.js

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    5d07d9a View commit details
    Browse the repository at this point in the history

  7. Rewrite tabs handling to be driven by Redux 

    Moved TabBar to common/components
Added reducer utility functions
Added tab handling logic
Added TabContainer
Added tabs reducer to root reducer
Removed dead test reducer
Changed TabBar to be a functional component, since it's now stateless
    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    f582938 View commit details
    Browse the repository at this point in the history

  8. Upgrade Semantic-UI-React to 0.61.0 

    I was previously on 0.60.9.  Unfortunately, that apparently had a huge
performance issue, due to the way Lodash was being used to omit props
that components didn't handle themselves.  That resulted in increasingly
slow performance to switch tabs as I added more components per tab
panel (and not that many components, either!).  The perf issue was
fixed in 0.60.10, naturally.

References:

Semantic-Org/Semantic-UI-React#860
Semantic-Org/Semantic-UI-React#864
    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    d76e673 View commit details
    Browse the repository at this point in the history

  9. Fix linting complaints 

    Removed unused component imports
Added keys to tabs and tab panels
    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    538982c View commit details
    Browse the repository at this point in the history

  10. Make tab bar bigger

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    b8c55f3 View commit details
    Browse the repository at this point in the history

  11. Add initial Pilots tab layout with hardcoded content

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    6fb5e60 View commit details
    Browse the repository at this point in the history

  12. Add initial Mechs tab layout with hardcoded content

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    8d17d90 View commit details
    Browse the repository at this point in the history

  13. Add initial Unit Organization tab layout with hardcoded content

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    0a08b98 View commit details
    Browse the repository at this point in the history

  14. Tweak hardcoded values for unit info and pilot info

    @markerikson
    markerikson committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    076c3a5 View commit details
    Browse the repository at this point in the history