Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.watch - fix race condition #16

Merged
merged 5 commits into from
Jan 30, 2018
Merged

fs.watch - fix race condition #16

merged 5 commits into from
Jan 30, 2018

Conversation

markis
Copy link
Owner

@markis markis commented Jan 30, 2018

With #6, When jest executes onRunComplete coverage hasn't be evaluated yet, so the new coverage summary hasn't been written to the file.

This will watch the coverage file for changes rather than just read the file at onRunComplete

@coveralls
Copy link

coveralls commented Jan 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+5.4%) to 95.69% when pulling fd56dc8 on watcher into 4746e10 on master.

@markis markis merged commit 8dbe7b6 into master Jan 30, 2018
@markis markis deleted the watcher branch January 30, 2018 07:07
@markis markis mentioned this pull request Jan 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markis @coveralls