[1.x] Fix PHP 8.2 compat issue in uses of DateTime::modify()
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased and G2G |
mbabker
changed the title
DateTime::modify()DateTime::modify()
maxhelias
approved these changes
Dec 7, 2022
mbabker
force-pushed
the
php-8.2-compat-fix
branch
from
a06c98d
to
d157e7f
Compare
|
@maxhelias any update missing for merge this to master? Compat with 8.2 is very important for next upgrades. Thanks |
|
@shakaran I am not the owner or a collaborator. Thanks |
|
@mbabker just pinging you in case that you can check this for quick merge. Thanks |
|
I don't have merge rights here. |
who has? By contributions maybe @markitosgv (composer author) or @paulchubatyy ? |
deluxetom
approved these changes
Jan 17, 2023
mbabker
force-pushed
the
php-8.2-compat-fix
branch
from
d157e7f
to
b050582
Compare
|
Superseded by #361 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in php/php-src#9950 there is a behavioral change in PHP 8.2 if you make a call like
$dateTime->modify('+-300 seconds')as a result of another bug fix in the date/time handling libraries. As the bundle does not enforce TTLs to be a positive number (and the functional tests abuse this a bit), this is a practical fix to ensure anything passing a negative TTL value doesn't catastrophically break.