Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java Client and other dependencies #129

Closed
rjrudin opened this issue Mar 9, 2021 · 2 comments
Closed

Upgrade Java Client and other dependencies #129

rjrudin opened this issue Mar 9, 2021 · 2 comments
Milestone

Comments

@rjrudin
Copy link
Contributor

rjrudin commented Mar 9, 2021

Both marklogic-junit5 and marklogic-unit-test-client are using 4.x of the Java Client; 5.4.0 is now available.

Should also bump up all dependencies in marklogic-junit5 to latest versions.

It appears that the DHF dependency can be removed - it's compileOnly, but I don't see it being used anywhere.

@rjrudin rjrudin added this to the 1.1.0 milestone Mar 9, 2021
@venuiyengar
Copy link
Contributor

I removed compileOnly dependency for DHF. However, in order to compile I needed to add the following:
api "com.fasterxml.jackson.core:jackson-databind:2.12.2"
api "org.slf4j:slf4j-api:1.7.30"

I guess this should be OK!
I also bumped versions for other dependencies
marklogic-junit5 tests runs without any issues

@rjrudin
Copy link
Contributor Author

rjrudin commented Mar 10, 2021

That's correct - Java Client 5.4 switched to Gradle's api/implementation configurations, which means not every dependency comes over automatically (which is intentional).

Check the version number of Jackson that Java Client 5.4 is using though - I think it's 2.11.1, in which case you should use jackson-databind 2.11.1

You can run "gradle dependencies" to see all the dependencies and verify you don't have a mismatch of version numbers.

jamesagardner pushed a commit that referenced this issue Mar 19, 2021
* Fixing Issue #129 and #130: Use recommended gradle configurations instead of deprecated ones, removing datahub dependency.
@rjrudin rjrudin closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants