Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Set exit code when setup:do-setup fails #369

Closed
mblakele opened this issue Feb 7, 2015 · 3 comments
Closed

Set exit code when setup:do-setup fails #369

mblakele opened this issue Feb 7, 2015 · 3 comments
Labels
Milestone

Comments

@mblakele
Copy link
Contributor

mblakele commented Feb 7, 2015

It would be nice if ./ml dev bootstrap would set the exit code to a non-zero value if setup:do-setup fails. That would allow shell commands like ./ml dev bootstrap && ./ml dev deploy modules to work as expected.

@dmcassel dmcassel self-assigned this Feb 8, 2015
@grtjn grtjn modified the milestone: 1.7.2 Feb 20, 2015
@grtjn
Copy link
Contributor

grtjn commented Feb 21, 2015

ml.rb needs to be fixed like this on two places:

        result = ServerConfig.send command
        if !result
          exit!
        end

I think we just need to make sure that all commands return true if ok..

@grtjn
Copy link
Contributor

grtjn commented Feb 21, 2015

@dmcassel are you working on this?

@grtjn grtjn added the bug label Feb 21, 2015
@dmcassel dmcassel removed their assignment Feb 22, 2015
@dmcassel
Copy link
Collaborator

I'd intended to, but got pulled onto other things.

paxtonhare added a commit that referenced this issue Mar 10, 2015
Fixed #369: improved returning exit code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants