Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated APIs #621

Closed
sammefford opened this issue Jan 11, 2017 · 8 comments
Closed

Remove deprecated APIs #621

sammefford opened this issue Jan 11, 2017 · 8 comments

Comments

@sammefford
Copy link
Contributor

Many APIs were deprecated in ML8 and therefore are ready to be removed in ML9

@kcoleman-marklogic
Copy link
Contributor

Sam, I have to put all this stuff into the release notes. I've tried to sift them all out of the diffs, but I'm going to have dump a review task on you because I probably missed something.

@sammefford
Copy link
Contributor Author

ok, thanks Kim!

georgeajit added a commit that referenced this issue Feb 3, 2017
@georgeajit georgeajit added fix and removed test labels Feb 3, 2017
@georgeajit
Copy link
Contributor

Kim,

I have assigned this issue to you for documentation tasks, and status has been changed to fix, for now. Please change the Git labels and assignment, if this is not correct.

@kcoleman-marklogic
Copy link
Contributor

That's fine, Ajit, thank you. I'll reassign it to Sam for review once the release notes are ready, unless you would like to do the review instead.

@kcoleman-marklogic
Copy link
Contributor

The release note for the removed things is here:

http://pubs.marklogic.com:8011/9.0/guide/relnotes/chap4#id_23217

It includes both the items covered by this bug and the key-value interfaces that were probably removed previously. @sammefford please review between now and release, or pawn it off on Ajit. :)

@sammefford
Copy link
Contributor Author

sammefford commented Feb 3, 2017

Some ideas:

  • ServerConfigurationManager.setContentVersion appears to be missing from the list
  • Change "Create query options 'manually' instead of using these classes." to "Instead of using these classes, create query options using your preferred JSON or XML libraries, or read options from a file, or build options as a string. Also read or write options using handles such as DOM4JHandle, JacksonHandle, FileHandle, or StringHandle."
  • Change "Calls to these methods were previously ignored" to "Calls to these methods were ignored in MarkLogic 8"
  • these weren't removed (just changed to interfaces rather than public classes): Point, Polygon, Box, Circle

@kcoleman-marklogic kcoleman-marklogic removed their assignment Apr 23, 2017
@kcoleman-marklogic
Copy link
Contributor

Sam, you said ServerConfigurationManager.setContentVersion is missing from the release note, but I can't find any such method in either the ML8 or ML7 javadoc. There are deprecated get/setContentVersionRequests methods, and those are reflected in the release notes.

I'm going to assume this is a misunderstanding unless I hear otherwise from you. I've incorporated the rest of your corrections, so unless I need straightening out on the content versioning thing, you can close this.

@sammefford sammefford added ship and removed test labels Apr 24, 2017
@sammefford
Copy link
Contributor Author

Looks like I was mistaken in saying ServerConfigurationManager.setContentVersion. I can see that ServerConfigurationManager.get/setContentVersionRequests are in the release notes as two of the removed methods, so I agree you captured that.

@sammefford sammefford added closed and removed ship labels May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants