Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support DocumentManager.setReadTransform for DocumentManager.search calls #639

Closed
sammefford opened this issue Jan 25, 2017 · 3 comments
Closed

Comments

@sammefford
Copy link
Contributor

Just as we support QueryDefinition.setResponseTransform when a call is made to DocumentManager.search(QueryDefinition, long), we should also support DocumentManager.setReadTransform for those calls. We should throw an error if both are specified but with different transforms.

@sammefford sammefford added this to the N/A milestone Jan 25, 2017
@sammefford sammefford self-assigned this Jan 25, 2017
@ltnd
Copy link

ltnd commented May 2, 2017

+1 on this.
DocumentManager.setReadTransform is a method available on the Java API but the transform parameter is not sent when calling the search. This should be good as the REST API on ML side allows it.

@sammefford sammefford modified the milestones: java-client-api-4.0.3, N/A May 2, 2017
sammefford added a commit that referenced this issue Sep 13, 2017
@sammefford sammefford assigned georgeajit and unassigned sammefford Sep 13, 2017
@sammefford sammefford added test and removed fix labels Sep 13, 2017
@sammefford
Copy link
Contributor Author

Ajit, I added a unit test which tries

  1. with only documentManager.setReadTransform
  2. with both documentManager.setReadTransform and queryDefinition.setResponseTransform set to the same transform

I haven't tested with documentManager.setReadTransform and queryDefinition.setResponseTransform set to different transforms. I also didn't test using documentManager.setReadTransform and passing in a SearchReadHandle to verify it gets transformed also. Other than that I'm not seeing anything else to test here.

@georgeajit
Copy link
Contributor

Shipping the Task. Pending Git issues on this feature will be handled separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants