Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file name to contain [some word] #1166

Merged
merged 2 commits into from
Nov 12, 2018

Conversation

aganeshalingam
Copy link
Contributor

Add support for file name to contain [mobile]

@jsf-clabot
Copy link

jsf-clabot commented Nov 8, 2018

CLA assistant check
All committers have signed the CLA.

@seangates
Copy link
Contributor

That's a lot of extra whitespace changes.

@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #1166 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1166   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files         311      311           
  Lines       11796    11796           
=======================================
  Hits        10678    10678           
  Misses       1118     1118
Impacted Files Coverage Δ
...onents/taglib/TransformHelper/getComponentFiles.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f8b39...aa997e8. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 90.522% when pulling aa997e8 on aganeshalingam:master into 76f8b39 on marko-js:master.

@seangates
Copy link
Contributor

@aganeshalingam 👍

@DylanPiercey
Copy link
Contributor

Let it be know that I think this is a really strange PR and that this intent is to better support for https://github.com/eBay/arc.

Having said that the impact here is really small. Will merge this, but hopefully we find a different solution so that Marko does not need to know about arc.

@DylanPiercey DylanPiercey merged commit e621b83 into marko-js:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants