Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix macro with injected renderBody migration #1300

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

mlrawlings
Copy link
Member

Description

In addition to <macro-body> a special renderBody property used to be injected into the <macro> tag. The migration did not account for this.

<macro test()>
  $ renderBody(out);
</macro>

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #1300 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   90.54%   90.56%   +0.02%     
==========================================
  Files         339      339              
  Lines       12411    12416       +5     
==========================================
+ Hits        11237    11245       +8     
+ Misses       1174     1171       -3
Impacted Files Coverage Δ
src/taglibs/migrate/macro-tag.js 100% <100%> (ø) ⬆️
src/compiler/Walker.js 93.75% <0%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d161213...cc2a4c9. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.569% when pulling cc2a4c9 on macro-renderbody-fix into d161213 on master.

@DylanPiercey DylanPiercey merged commit 9cb22a9 into master Mar 27, 2019
@DylanPiercey DylanPiercey deleted the macro-renderbody-fix branch July 8, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants