Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid browser remap for preserve tag #1921

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Avoids using a package.json remap for the browser implementation of the <_preserve> internal tag (used to implement no-update directives). This fixes an issue where in vite the module could not be loaded properly.
  • Avoid using typeof window and prefer typeof document checks for browser environment (improves future deno support).

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

🦋 Changeset detected

Latest commit: ee0da05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/compiler Patch
marko Patch
@marko/translator-default Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit c41cda5 into main Mar 24, 2023
@DylanPiercey DylanPiercey deleted the avoid-browser-remap-for-preserve-tag branch March 24, 2023 16:07
@github-actions github-actions bot mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant