Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always load marko.json "exports" when in node_modules. #2252

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

DylanPiercey
Copy link
Contributor

  • Always load marko.json "exports" when in node_modules.
  • Reduce duplicate macro compiler error to a warning (with an auto fix)

Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: c9bf298

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@marko/compiler Patch
@marko/translator-default Patch
@marko/babel-utils Patch
marko Patch
@marko/runtime-tags Patch
@marko/translator-interop-class-tags Patch
@marko/translator-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.49%. Comparing base (e491e45) to head (c9bf298).

Files Patch % Lines
packages/babel-utils/src/diagnostics.js 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   87.48%   87.49%   +0.01%     
==========================================
  Files         333      333              
  Lines       33874    33885      +11     
  Branches     1860     1860              
==========================================
+ Hits        29634    29648      +14     
+ Misses       4229     4226       -3     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit bfe85d1 into main Jun 20, 2024
8 of 9 checks passed
@DylanPiercey DylanPiercey deleted the compat-fixes-06-20-24 branch June 20, 2024 16:49
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant