Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: referencing Marko.Component in a split component adds Marko to window #2289

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

LuLaValva
Copy link
Member

No description provided.

@LuLaValva LuLaValva self-assigned this Aug 30, 2024
Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 5b280b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (3286eac) to head (5b280b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2289   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         337      339    +2     
  Lines       35164    35166    +2     
  Branches     2085     2085           
=======================================
+ Hits        30942    30944    +2     
  Misses       4206     4206           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuLaValva LuLaValva merged commit e20e9af into main Aug 30, 2024
9 checks passed
@LuLaValva LuLaValva deleted the component-browser branch August 30, 2024 21:20
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant