Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make renderSync behave if no context was supplied #250

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Make renderSync behave if no context was supplied #250

merged 1 commit into from
Mar 18, 2016

Conversation

jsumners
Copy link
Contributor

This pull request fixes a case wherein if renderSync receives no context then it will still render the template. Currently, if you don't supply at least an empty object ({}) then renderSync bombs with an error like:

Debug: internal, implementation, error 
    TypeError: Uncaught error: Cannot read property '$global' of undefined
    at Object.Template.renderSync (/some/project/node_modules/marko/runtime/marko-runtime.js:109:17)
    ....

patrick-steele-idem added a commit that referenced this pull request Mar 18, 2016
@patrick-steele-idem
Merge pull request #250 from jsumners/missing-global
f878db5 
Make renderSync behave if no context was supplied
@patrick-steele-idem patrick-steele-idem merged commit f878db5 into marko-js:master Mar 18, 2016
@patrick-steele-idem
Copy link
Contributor

Thanks for the improvement! I'll publish in just a bit

@patrick-steele-idem
Copy link
Contributor

New version published: marko@3.0.3

Thanks again.

@jsumners
Copy link
Contributor Author

Excellent. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsumners @patrick-steele-idem