Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #420 - Deprecate w-on* attribute for widget events #434

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

ctdio
Copy link
Contributor

@ctdio ctdio commented Nov 15, 2016

Description

Deprecate w-on* attributes for handling widget events. Added support for registering event handlers with on*().

Motivation and Context

This is part of the Marko v4 roadmap.

Checklist:

  • My code follows the code style of this project.
  • I have updated/added documentation affected by my changes.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Nov 15, 2016

Coverage Status

Coverage increased (+0.6%) to 87.596% when pulling 63862a8 on charlieduong94:420-deprecate-w-on-attr into 3eb3c28 on marko-js:master.

@coveralls
Copy link

coveralls commented Nov 15, 2016

Coverage Status

Coverage decreased (-22.1%) to 64.874% when pulling 0716f90 on charlieduong94:420-deprecate-w-on-attr into 3eb3c28 on marko-js:master.

@ctdio ctdio force-pushed the 420-deprecate-w-on-attr branch 2 times, most recently from 64e5216 to cfc1d8c Compare November 15, 2016 20:32
@coveralls
Copy link

coveralls commented Nov 15, 2016

Coverage Status

Coverage decreased (-22.1%) to 64.874% when pulling cfc1d8c on charlieduong94:420-deprecate-w-on-attr into 3eb3c28 on marko-js:master.

Added support for on*() attributes.
@coveralls
Copy link

coveralls commented Nov 16, 2016

Coverage Status

Coverage decreased (-0.4%) to 86.541% when pulling e7ab99f on charlieduong94:420-deprecate-w-on-attr into 3eb3c28 on marko-js:master.

@ctdio ctdio changed the title Deprecated w-on* attribute for widget events Fixes #420 Deprecate w-on* attribute for widget events Nov 16, 2016
@ctdio ctdio changed the title Fixes #420 Deprecate w-on* attribute for widget events Fixes #420 - Deprecate w-on* attribute for widget events Nov 16, 2016
@ctdio ctdio mentioned this pull request Nov 16, 2016
@mlrawlings mlrawlings merged commit fc82ef0 into marko-js:master Nov 16, 2016
@mlrawlings
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants