Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test for dynamic attributes on custom html tag #918

Closed
wants to merge 1 commit into from

Conversation

yomed
Copy link
Contributor

@yomed yomed commented Nov 1, 2017

Description

Hi, this is not intended for merge, just to show an issue. Using dynamic attributes with custom html elements leads to the following error:

Error: Generating code for TemplateRoot node failed. 
Error: Error: Generating code for <custom-html-tag> tag failed.
Error: AssertionError [ERR_ASSERTION]: "name" should be a string

Checklist:

  • My code follows the code style of this project.
  • I have updated/added documentation affected by my changes.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Disclaimer: Contributions via GitHub pull requests are gladly accepted from their original author. Along with any pull requests, please state that the contribution is your original work and that you license the work to the project under the project's open source license. Whether or not you state this explicitly, by submitting any copyrighted material via pull request, email, or other means you agree to license the material under the project's open source license and warrant that you have the legal authority to do so.

@mlrawlings
Copy link
Member

mlrawlings commented Mar 6, 2018

I'm going to close this as it's just been sitting and the test structure has changed since this PR was opened. We now have a way to merge failing test cases, so if this is still an issue and someone can open a PR with a failing test case we'll take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants