Fast forward master into dev branch #2

marktrayer · 2023-05-31T22:31:40Z

Get dev branch up to date with underlying master

* tv-casting-app: turning off extended discovery (#170) * Moving mTimeSource declaration behind CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY

…26776) * [Darwin] MTRDevice should not always send reads to device directly * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/templates/MTRAttributeUtils-src.zapt Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address PR review comments --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Fix ThreadSanitizer failure in controller factory. The failure looks like this: WARNING: ThreadSanitizer: race on NSMutableArray (pid=11619) Read-only access of NSMutableArray at 0x7b0c0005f5b0 by thread T3: #0 -[__NSArrayM countByEnumeratingWithState:objects:count:] <null>:2 (CoreFoundation:x86_64+0x4a338) #1 -[MTRDeviceControllerFactory(InternalMethods) operationalInstanceAdded:] MTRDeviceControllerFactory.mm:855 (Matter:x86_64+0x1fd2a) #2 MTROperationalBrowser::OnBrowse(_DNSServiceRef_t*, unsigned int, unsigned int, int, char const*, char const*, char const*, void*) MTROperationalBrowser.mm:100 (Matter:x86_64+0x20ee63c) #3 handle_browse_response <null>:2 (libsystem_dnssd.dylib:x86_64+0x3733) #4 _dispatch_client_callout <null>:2 (libdispatch.dylib:x86_64+0x3316) Previous modifying access of NSMutableArray at 0x7b0c0005f5b0 by main thread: #0 -[__NSArrayM addObject:] <null>:2 (CoreFoundation:x86_64+0x2457a) #1 -[MTRDeviceControllerFactory createController] MTRDeviceControllerFactory.mm:719 (Matter:x86_64+0x1cee3) #2 -[MTRDeviceControllerFactory createControllerOnExistingFabric:error:] MTRDeviceControllerFactory.mm:534 (Matter:x86_64+0x19792) The basic problem is that we are in the middle of adding an object to _controllers on the API consumer thread when on the Matter thread we get our browse notification. The changes here don't aim to lock around all access to _controllers, but just to make sure that our mutations of it can't race with the access on the Matter thread. More coarse locking would need to be done very carefully, given the amount of dispath_sync to the Matter thread we have going on. * Address review comments.

* V1.0.0 branch 25023 fix (#110) * Lock the SDK before interacting with it. [Problem] The Matter SDK assumes that the client will take a lock on the SDK prior to interacting with any APIs. There is 1 Android function and several iOS functions that do not take the lock prior to interacting with the SDK APIs. There are also some functions that invoke the Matter SDK in a way that may result in out-of-order callback invocation (e.g. the conceptual "started" callback may be invoked after the conceptual "ended" callback). [Solution] Create utility functions that help ensure that the Matter SDK is invoked safely and that callbacks are delivered in the correct order. [Testing] Performed local, manual testing with the 'tv-casting-app' example on iOS against a Raspberry Pi running the 'tv-app'. Ran the certification test in the 'tv-casting-app' on iOS against the same Raspberry Pi. * * Updating naming and parameter order for new CastingServerBridge APIs * Refactored the Certification Tests to more fully exercise threading behavior * * Updating the documentation for modified APIs * Restyling --------- Co-authored-by: Michael Douglas <125094815+domichae-amazon@users.noreply.github.com>

* DNS-SD mock for checking platform implementations * Mark POSIX event loop as ready for run if not-internaly managed * Prevent SEGFAULT in test in case of resolve error * Document mDNS test cases * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* [ESP32] Do not select factory data provider and device instance info provider when secure cert dac provider is selected * Fix the linker error when building for esp32h2 * Move ieee802154 under openthread config

* Fixes issue 2524 TC-SC-5.3 TC-SC-6.1 * Restyled by whitespace * Added new manual testcase TC-ACE-1.6 Modified test TC-ACE-1.5 * Restyled by whitespace * Restyled by prettier-json --------- Co-authored-by: Restyled.io <commits@restyled.io>

…#26850) We had an extra queue hop for reports compared with the subscriptionEstablished notification, so the API consumer could get subscriptionEstablished before getting all the priming reports. The fix is to just ensure that the code flows the same way, in terms of queue dispatch, for both priming reports and subscriptionEstablished.

…26853) * Update silabs lighting zap configs. Set some Colorcontrol attributes to NVM to match spec * Also set startUpColorTemperatureMireds to NVM storage

…6812) * [BUG] Linux Test Harness Certification Declaration encoding error During internal QA testing related to commissioning the [chip-certification-tool (TH v 2.8.1 - 1.1 Release Build)](https://github.com/CHIP-Specifications/chip-certification-tool/releases/tag/v2.8.1-official) a failure occurred while attempting to verify the Certification Declaration payload using the latest releases of Bouncy Castle. > **11.17.5.5. Attestation Information** > > The certification_declaration field SHALL be the DER-encoded octet string representation of a CMS-formatted certification declaration, as described in Section 6.3, “Certification Declaration”. The [specific exception](https://github.com/bcgit/bc-java/blob/876bd0cf02811282707ddd38e4f0f9212a9f4d1f/core/src/main/java/org/bouncycastle/asn1/ASN1Primitive.java#L46-L49) is thrown while attempting to decode the DER-encoded octet string, due to unexpected bytes remaining after attempting to decode the packet. After extracting the Certification Declaration payload and attempting to perform manual validation using openssl, it was double-confirmed that the payload contained an encoding error. Finally, the Certification Declaration payload was confirmed to have an extra byte originating from the hardcoded test payload. After the extra byte is removed, the payload decoding is successful. * Reverted changes to generated files * Switched from sizeof to ArraySize.

* Add a lint for SuccessOrExit without assignment. This is almost always a mistake, since it loses track of the error involved. * Address review comment.

* [python] Remove dependency only used in testing PR #21567 added mobly as a default dependency of the Python Core CHIP library. The mobly package is only used by the Python testing framework in `src/python_testing/`. Allow to install extra dependency via `script/build_python.sh` flag and install them only when needed. * [python] remove now unnecessary dependency mobly * Apply restyle changes

)

… to use a variable (#26678)

…6763) * Add ways to construct cluster structs from the shared superclass. This is only relevant when a struct is being shared across multiple clusters. * Address review comment.

…6870)

* Bump third_party/pigweed/repo from `e72f0d5` to `da76d13` Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `e72f0d5` to `da76d13`. - [Commits](google/pigweed@e72f0d5...da76d13) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update clang.json value to make linter happy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com>

…ist/typing.Tuple (#26873)

* Do Not submit: Initial draft of TC-TIMESYNC-1.1 NOTE: THIS TEST WILL NOT WORK UNTIL THE SDK IMPL IS DONE. The intent is to allow the SDK developers to test against this test as they develop. * Add TC-TIMESYNC-1.1 to the in-development test list This means it will be excluded from the CI, but still present for use in the TE * Restyled by whitespace * Restyled by prettier-json * Restyled by prettier-yaml * Pull in controller-clusters.zap from #26082 * Add client pics * Fix in development test parsing for non hardcoded * zappity zappity zap - it mus be appeased. * zap...why are you like this. * Fix controller clusters * re-zap * Why were these missing in the first place? * Generated or hardcoded? Why not both? * Add test to the disabled list for darwin * regen again. Hoping the 10th time's the charm * Fix revision, add event list * Restyled by autopep8 * Merge conflict. again. --------- Co-authored-by: Restyled.io <commits@restyled.io>

* Add Cluster Definition * Add New Cluster Definition to Required Files * Add New Clusters to ZAP Cluster List * Enable New Clusters in Controller * Update Feature Map Name * Add Generated Code * Update Generated Code * Add Expected Build Files * Remove Min Max Values for Floating Point Numbers * Fix Type Names Should match spec * Update Cluster Names Adding „Concentration“ to the cluster name. This naming convention maintains the integrity of the base cluster's name while also specifying the unique substance that the aliased version pertains to. * Update Generated Code * Update Expected Files * Update src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update Generated Code * Add Missing Expected Generated Files * Update Generated Code * Update Data Type AVG_MEASURED_VALUE_WINDOW and PEAK_MEASURED_VALUE_WINDOW are using elapsed_s as per spec. * Fix Java Build * Fix Merge Chaos Lines were added twice due to poor merging 🙁 * Update Generated Code * Change Cluster Definition Rename VOC_CONCENTRATION_MEASUREMENT_CLUSTER to TVOC_CONCENTRATION_MEASUREMENT_CLUSTER --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* update Identify cluster XML and generate code * cleaned up identify server implementation * update generated code references in Identify cluster examples * avoid using namespace in header and update identify init signature * update last pieces of legacy identify generated code * update missed references to legacy generated code * fix typo * fixed logging errors * update namespace usage * fixed few more namespace usage and cast * few more missed namespace updates * Update examples/chef/efr32/src/AppTask.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update examples/light-switch-app/silabs/efr32/src/AppTask.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update examples/lighting-app/nxp/k32w/k32w0/main/AppTask.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * address PR comments * regenerate code after removing feature map from XML and running zap_convert_all.py * fix CI errors * trying to fix types * added missing namespace * No need for spurious changes. And for a 16-bit int, 0x00 is not any more "correct" than 0x0. Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Revert warning fixes which are not neccessary * shorten namespace use * run restyler * regen Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * fix spell check * Fix new pump-app example. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

WARNING: ThreadSanitizer: race on NSMutableDictionary (pid=72050) Modifying access of NSMutableDictionary at 0x7b0800149020 by thread T7: #0 -[__NSDictionaryM setObject:forKey:] <null>:2 (CoreFoundation:x86_64+0x40d4e) #1 -[MTRXPCListenerSample listener:shouldAcceptNewConnection:] MTRXPCListenerSampleTests.m:116 (MatterTests:x86_64+0x48437b) #2 service_connection_handler_make_connection <null>:2 (Foundation:x86_64+0xdea93) Previous modifying access of NSMutableDictionary at 0x7b0800149020 by thread T4: #0 -[__NSDictionaryM removeObjectForKey:] <null>:2 (CoreFoundation:x86_64+0x6cd6d) #1 __59-[MTRXPCListenerSample listener:shouldAcceptNewConnection:]_block_invoke MTRXPCListenerSampleTests.m:119 (MatterTests:x86_64+0x484630)

…26880)

* Add Air Quality Cluster to All Clusters Example (#26765) * Add missing .matter file * Add MatterAirQualityPluginServerInitCallback() to util.cpp needed for some build targets (#26765) * Update Featuremap from 0 to 15 To include all the features in the all clusters example app.

* Resolving conflicts to rebase onto master * Reverted files creating problems * Added manual configuration options for AC and now getting the capacity from the maximum number of scenes on DUT. * Reverted or condition on StoreScene test allowing INSUFFICIENT SPACE, not currently allowing it. Added check on RecallScene return where expected, updated 2_3 and 2_4 to hybrid between automated and manual per app tests * Restyled by whitespace * Restyled by prettier-yaml * Added anyOf to check wether 0x00 or 0x89 was returned for store scenes commands where it was accepted * Restyled by whitespace * Restyled by prettier-yaml * Reverted runIf, anyOf and UnsignedNumberEquals commands for now until the new test backend is implemented. * Resolved conflicts for : Modified AttribueValue in Scenes::AttributeValuePair to now be a uint32_t according to upcoming spec change * Restyled by prettier-yaml * Refactored tests and SceneTable default handlers to the uint32_t type for the AttributePairValue * Regenerated zap files for all-cluster apps * Regenerated zap files for chip-tool * Applied corrections to 2_4 to follo test plan * Restyled by whitespace * Restyled by prettier-yaml * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Added missing checks, modified wrong description to match test plan * Restyled by whitespace * Restyled by prettier-yaml * Regenerated after rebase * Added variable for G1 in Test_TC_s_2_3, changed GroupKeySecurityPolocy to 0 in 2.2 and 2.3 and removed Scene 0x03 from firt scene membership response in 2.3 * Applied restyler * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

…6876)

* Fix constexpr complaints on test vectors * Attempt #2 - separate PAAs used in non-test * Things work better when we add all the files * Restyled by whitespace * Restyled by clang-format * add tokenizer * add the gni * add pigweed import * Change filenames * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>

…ist". (project-chip#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) #3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) project-chip#4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) project-chip#5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) project-chip#6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) project-chip#7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) project-chip#8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) project-chip#9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) project-chip#10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) project-chip#11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) project-chip#12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) project-chip#13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) project-chip#14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) project-chip#15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) project-chip#16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) project-chip#17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) project-chip#18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) project-chip#19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) project-chip#20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) project-chip#21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)

* Adds MdnsDiscovery class * Fix restyle/lint * Fix restyle * Adds zeroconf dependency in tests.yaml * Relocates zeroconf dependency from tests.yaml to requirements.txt * Addresses latest review comments * Fixes typo * Updates instantiation method and initial discovery * Fix restyle/lint * Addresses latest review comments * Addresses latest review comments * Fix restlye/lint * Addresses review comments * restore enum * Refactor progress * Major refactor to discover() and get_operational_service_info, pending other get methods * Fix restyle * Fix restyle/lint * Updates descriptions and variables * Major refactor #2 * Fix restyle * Updates method descriptions * Fix restyle * Addresses review comments * Fix restyle * Fix lint * Default parameters adjustment --------- Co-authored-by: C Freeman <cecille@google.com>

* Modifed YAML tests: TC_DISHM_1_2 TC_DISHM_2_1 TC_DISHM_3_1 TC_DISHM_3_3 TC_LWM_1_1 TC_LWM_1_2 TC_OTCCM_1_1 TC_OTCCM_1_2 TC_OTCCM_2_1 TC_OTCCM_3_1 TC_OTCCM_3_3 TC_TCCM_1_1 TC_TCCM_1_2 * Auto generated files * Restyled by whitespace * Fix the CI failure for LWM-1.1 & TCCM-1.1 test * Fix CI failure OTCCM-1.1 test * Revert tests TC-LWM-1.1 TC_TCCM-1.1 TC-OTCCM-1.1 * Fixes issue: 109, 110, 111, 112, 113, 114, 115, 116 TC-CNET-4.1 TC-CONTENTLAUNCHER-10.4 TC-DRYERCTRL-2.1 TC-MEDIAPLAYBACK-6.8 TC-MEDIAPLAYBACK-6.9 TC-MEDIAPLAYBACK-6.10 TC-OTCCM-1.2 * Restyled by whitespace * Modifed YAML tests: TC_DISHM_1_2 TC_DISHM_2_1 TC_DISHM_3_1 TC_DISHM_3_3 TC_LWM_1_1 TC_LWM_1_2 TC_OTCCM_1_1 TC_OTCCM_1_2 TC_OTCCM_2_1 TC_OTCCM_3_1 TC_OTCCM_3_3 TC_TCCM_1_1 TC_TCCM_1_2 * Auto generated files * Restyled by whitespace * Fix the CI failure for LWM-1.1 & TCCM-1.1 test * Fix CI failure OTCCM-1.1 test * Revert tests TC-LWM-1.1 TC_TCCM-1.1 TC-OTCCM-1.1 * Fixes issue: 109, 110, 111, 112, 113, 114, 115, 116 TC-CNET-4.1 TC-CONTENTLAUNCHER-10.4 TC-DRYERCTRL-2.1 TC-MEDIAPLAYBACK-6.8 TC-MEDIAPLAYBACK-6.9 TC-MEDIAPLAYBACK-6.10 TC-OTCCM-1.2 * Restyled by whitespace * Fix conflict * Fix merge * Fix merge * Modifed YAML tests: TC_DISHM_1_2 TC_DISHM_2_1 TC_DISHM_3_1 TC_DISHM_3_3 TC_LWM_1_1 TC_LWM_1_2 TC_OTCCM_1_1 TC_OTCCM_1_2 TC_OTCCM_2_1 TC_OTCCM_3_1 TC_OTCCM_3_3 TC_TCCM_1_1 TC_TCCM_1_2 * Auto generated files * Restyled by whitespace * Fix the CI failure for LWM-1.1 & TCCM-1.1 test * Fix CI failure OTCCM-1.1 test * Revert tests TC-LWM-1.1 TC_TCCM-1.1 TC-OTCCM-1.1 * Fixes issue: 109, 110, 111, 112, 113, 114, 115, 116 TC-CNET-4.1 TC-CONTENTLAUNCHER-10.4 TC-DRYERCTRL-2.1 TC-MEDIAPLAYBACK-6.8 TC-MEDIAPLAYBACK-6.9 TC-MEDIAPLAYBACK-6.10 TC-OTCCM-1.2 * Restyled by whitespace * Fix merge * Fix merge * remove dead java encode_value.zapt (#31896) * Move getting the reboot cause to platform abstraction. Set a getter for the reboot cause so different stacks can obtain it (#31891) * Bump third_party/imgui/repo from `96839b4` to `f50ddc4` (#31917) Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `96839b4` to `f50ddc4`. - [Release notes](https://github.com/ocornut/imgui/releases) - [Commits](https://github.com/ocornut/imgui/compare/96839b445e32e46d87a44fd43a9cdd60c806f7e1...f50ddc431e3b8840036e88abc4c3cf74500aa12b) --- updated-dependencies: - dependency-name: third_party/imgui/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump third_party/nanopb/repo from `f8724ee` to `1f0c2e1` (#31915) Bumps [third_party/nanopb/repo](https://github.com/nanopb/nanopb) from `f8724ee` to `1f0c2e1`. - [Commits](https://github.com/nanopb/nanopb/compare/f8724ee54b3733aebfc25ac0ed5e8b142569c59e...1f0c2e19c661f18dd88428858b8e965a26589e03) --- updated-dependencies: - dependency-name: third_party/nanopb/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump third_party/openthread/repo from `bf587dd` to `cf357d7` (#31912) Bumps [third_party/openthread/repo](https://github.com/openthread/openthread) from `bf587dd` to `cf357d7`. - [Release notes](https://github.com/openthread/openthread/releases) - [Commits](https://github.com/openthread/openthread/compare/bf587dd09005abc49a5595f8691afb9512fac9c1...cf357d70be94e6f3f21d07b3c16e29bb7ec5cc7e) --- updated-dependencies: - dependency-name: third_party/openthread/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/issue-labeler from 3.3 to 3.4 (#31918) Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 3.3 to 3.4. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](https://github.com/github/issue-labeler/compare/v3.3...v3.4) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump natiginfo/action-detekt-all from 1.23.4 to 1.23.5 (#31919) Bumps [natiginfo/action-detekt-all](https://github.com/natiginfo/action-detekt-all) from 1.23.4 to 1.23.5. - [Release notes](https://github.com/natiginfo/action-detekt-all/releases) - [Commits](https://github.com/natiginfo/action-detekt-all/compare/1.23.4...1.23.5) --- updated-dependencies: - dependency-name: natiginfo/action-detekt-all dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add "orphan" files from bdx to gn (#31874) * Add "orphan" files from bdx to gn This should help layer enforcement. * Restyle * Increase number of retries on websocket in YAML test harness. (#31893) We seem to be hitting the 4-retry cap a lot. The question is whether waiting an extra few seconds would help or not. Co-authored-by: Andrei Litvin <andy314@gmail.com> * Add missing function to set delegate in Door Lock Server (#31846) * Add missing function to set delegate in Door Lock Server * Restyled by clang-format (#31847) Co-authored-by: Restyled.io <commits@restyled.io> --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * Bump third_party/mbedtls/repo from `1b9cea3` to `6b36a5d` (#31913) Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `1b9cea3` to `6b36a5d`. - [Release notes](https://github.com/ARMmbed/mbedtls/releases) - [Commits](https://github.com/ARMmbed/mbedtls/compare/1b9cea30b1d59a42df7d0f98aed97462985d42d5...6b36a5db07ae0e299c9e67f526c28db93e586e25) --- updated-dependencies: - dependency-name: third_party/mbedtls/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Scenes] Test Update (#31614) * Updated PICS and server yamls Test_TC_... to fit test plan * Apply suggestions convert hex to dec base Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> * Updated remaining transition times and added delay for Darwin CI test * Added verification for steps 4b and 4c in TC_S_2_5 * Restyled by whitespace * Restyled by prettier-yaml * Removed Un-necessary PICS, added verification where it was missing in TC_S_2_5 and TC_S_2_6 --------- Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * Bump third_party/ot-br-posix/repo from `13d583e` to `9326cc3` (#31914) Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `13d583e` to `9326cc3`. - [Release notes](https://github.com/openthread/ot-br-posix/releases) - [Commits](https://github.com/openthread/ot-br-posix/compare/13d583e361c7038b967b601d5e5f6739b0bcf736...9326cc38b6b6ce81958a96d7821c4cb21976d636) --- updated-dependencies: - dependency-name: third_party/ot-br-posix/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Tizen] Use spec complaint BLE advertising intervals (#31790) * [Tizen] Use spec complaint BLE advertising intervals * Transition from fast adv to slow after timeout * Refactor Tizen specific BLE initialization function * Use ScheduleLambda instead of ScheduleWork * Wrap C callbacks with lambda to make methods non-static * Define BLE_CONNECTION_OBJECT for Tizen platform * Get rid of another static method * Update name to align with convention * Do not use sInstance directly if possible * Added the --app-pid flag to the python matter testing support (#31866) * Added the --app-pid flag to the python matter testing support to provide a way for test scripts to get the PID of the app they are running against. * fixed typo. Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com> --------- Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com> * TC-ACE-2.1/2: Update default timeout (#31643) * TC-ACE-2.1/2: Update default timeout * Fix default timeout Hey, you know what helps? Committing changes in the correct branch before uploading. * python testing: Add PICS parser for xml (#31493) * python testing: Add PICS parser for xml Code blatently stolen from Jon Rhees. * Restyled by isort * remove some debug --------- Co-authored-by: Restyled.io <commits@restyled.io> * [Linux] Do not reuse cancellable object (#31828) * [Linux] Do not reuse cancellable object Per documentation for g_cancellable_reset(): > Note that it is generally not a good idea to reuse an existing > cancellable for more operations after it has been cancelled once, as > this function might tempt you to do. The recommended practice is to > drop the reference to a cancellable after cancelling it, and let it > die with the outstanding async operations. * Update cancellable in ChipDeviceScanner * [ICD] Refactor ICDManager to use System::Clock types (#31881) * Refactor time members * add using namespace * Fix ActiveModeThreshold type and cast * [MatterYamlTests][darwin-framework-tool] Use a list of tests to run f… (#31792) * Properly handle Aliro credential validation in door lock server (#31932) * Handle Aliro credential in door lock server * Restyled by clang-format (#31933) Co-authored-by: Restyled.io <commits@restyled.io> * Update src/app/clusters/door-lock-server/door-lock-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Restyled by clang-format (#31935) Co-authored-by: Restyled.io <commits@restyled.io> * Update constant name from git chage * Update to use SupportsAliroProvisioning API --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Implement support for more configurable server endpoints in Matter.framework. (#31814) * Implement support for more configurable server endpoints in Matter.framework. * Public APIs on MTRDeviceController to add/remove an endpoint. * Internal APIs on MTRDeviceController to query the access grants for a cluster path and the declared "minimum privilege needed" to read a given attribute. * Changes to the controller factory to stop using app/dynamic_server and instead use the new infrastructure to expose OTA Provider on endpoint 0. * Internal APIs on the controller factory to query access grants and declared privileges. * An implemenation of AccessControl::Delegate to do ACL checks using the above-mentioned APIs. * A fix to MTRServerAttribute's setValue for arrays: it was not expecting the correct data-value structure for an array. This requires fixing some tests too, to provide the right structures. * Changes to the MTRServer* data structures to allow passing nil to associateWithController, to support the OTA endpoint which is not associated with any controller. * Changes to MTRServerCluster to create an AttributeAccessInterface, the set of EmberAfAttributeMetadata needed to represent its attributes, and various other things needed to register a cluster with the "ember" bits. * Changes to MTRServerEndpoint to create an EmberAfEndpointType, a list of EmberAfCluster, and various other things needed to register an endpoint with the "ember" bits. * (Re-)addition of MTRIMDispatch to handle command dispatch for OTA and host a few other functions the "ember" bits expect to exist. * Addition of some headers that the "ember" bits expect to exist at specific paths and with some specific content: "app/PluginApplicationCallbacks.h" and "zap-generated/endpoint_config.h". Importantly, the latter sets FIXED_ENDPOINT_COUNT to 0. * Addition of unit tests that exercise the non-OTA bits of the above (OTA is covered by existing tests), including the ACL checks and so on. * Including a bunch of src/app and src/app/util files needed for the "ember" stuff to work in the framework. * Turning off the chip_build_controller_dynamic_server bit that we are no longer using (and which conflicts with the above bits). * Configure Darwin to support 254 dynamic endpoints (the maximum that makes sense) by default. * Adjusting include paths for the Xcode darwin-framework-tool project, so that it sees the new headers that were added. * Address review comments. * Fix test timeout due to resolving IPv4 non-locahost addresses. * Remove stale comment. * EFR32 and SiWx917 can now use the same ConfigurationManagerImpl.cpp implementation (#31939) * Remove vestige of the initial ICD event base management (#31940) * [darwin-framework-tool] Remove codegen tests (#31942) * Add strong guarantee on monotonicity of system clock (#31885) * Add strong guarantee on monotonicity of system clock - It was observed some platforms have decrementing values from `SystemClock::GetMonotonicMilliseconds64()` implementation which can violate the required invariant that they NEVER go back, since multiple deadlines are computed from this clock, which could then never hit. This was observed to break in the field in subtle ways after ~48 days (2^32 milliseconds). - This change introduces a VerifyOrDie to allow crash/restart if the invariant is broken, since that leaves the stack in a possibly wedged state. - The new invariant is constructed to be reentrant-safe to maintain the invariant, in a way that it will eventually be caught, even if there are many threads/cores calling `GetMonotonicTimestamp()`. This was done in a lock-free manner, and was added since the public API of SystemLayer is not guaranteed to only be called from Matter thread context. Issue #31875 Testing done: - All unit tests still pass. - All integration tests still pass. - When `mockClock.AdvanceMonotonic(200_ms);` is replaced with `mockClock.AdvanceMonotonic(0xffff'ffff'ffff'ffff_ms);` in `TestSystemTimer.cpp::CheckOrder()`, the test crashes as expected due to detection of wraparound. * Fix review comments and move to intrinsics * Restyled by clang-format * Fix build and add warning * Fix build * Restyled by clang-format * Address review comment, add new define instead of linux && darwin * Restyled by clang-format --------- Co-authored-by: tennessee.carmelveilleux@gmail.com <tennessee@google.com> Co-authored-by: Restyled.io <commits@restyled.io> * Initial XML for Power Topology cluster (#31689) * Initial XML for Power Topology cluster * Regen * Restyled really wants newlines at the end of every JSON file * Rename LeafTopology to TreeTopology * [Linux] Add support for extended advertisement (#31668) * Use ScheduleLambda() instead of ScheduleWork * Set min/max advertisement interval * Matter BLE advertisement type shall be peripheral * Allow intervals to be set after initialization * Keep BlueZ default for adv slicing duration * Allow to update intervals on the fly - fast/slow * Transition to slow advertising after timeout * Fix advertisement typos in all places in the codebase * Do not specify advertisement timeout in BlueZ * Add support for extended advertisement * Post review changes - add manual how to enable experimental features in BlueZ * Restyled by prettier-markdown * Assert that extended adv interval is >= fast adv interval * Cancel HandleAdvertisingTimer timer in case of error --------- Co-authored-by: Restyled.io <commits@restyled.io> * ESP32: Add a menuconfig option to enable/disable persist subscription (#30889) * ESP32: Add a menuconfig option to enable/disable persist subscription * enable persistent subscription by default * Regenerate ZAP after merge conflict (#31956) * Make the help text for write-by-id say the right thing about the value list. (#31884) https://github.com/project-chip/connectedhomeip/pull/20413 changed the value separator from comma to semicolon, but did not change the help text. Fixes https://github.com/project-chip/connectedhomeip/issues/31854 * Improve the logic around schedule application in LockEndpoint. (#31946) The old logic had several bugs: * For kYearDayScheduleUser users, there was no schedule enforcement at all, since the outer "if" never tested true. * For kWeekDayScheduleUser users, there was no schedule enforcement at all, since the inner "if" never tested true. * For kScheduleRestrictedUser users, access was allowed if there was any schedule, weekday or yearday, that granted access. But the intent is that access should be disallowed if there are year day schedules and none of them grants access, no matter what's going on with weekday. And vice versa. * Make it clearer that cluster-enums-check is returning kUnknownEnumValue. (#31951) Instead of hardcoding the returns via the ZAP template, just use the symbolic name. * Spell out inet and lwip sources in GN (#31931) * Spell out inet and lwip sources Prepare to have some scripts that force all headers/sources to be known to GN. * Fix some copy and paste issues * Another copy and paste issue fixed * Restyle * Board-specific LWIP options for silabs boards (rs911, wf200, thread) were never used (#31929) * Add silabs-specific lwip options to GN * Make the lwipopts conditional * Revert "Make the lwipopts conditional" This reverts commit ff91e81193fad3b2b4941048122a1b9353cb6b3f. * Add another dependency for lwip * Remove TAP support from lwip (#31886) * Update SupportsAnyCredential function to include Aliro (#31949) * Update SupportsAnyCredential function to include Aliro * Restyled by clang-format (#31950) Co-authored-by: Restyled.io <commits@restyled.io> --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * Implement PayloadTestRequest command in DGGEN (#31907) * Add DataModelTest feature to general diagnostics * Regen ZAP * Fix TC-DGGEN-1.1 * Restyled by whitespace * Restyled by clang-format * Restyled by prettier-json * Restyled by isort * Fix integration tests * Fix Java codegen * Address review comments * Fix Java codegen * Fix Java codegen * Fix Java codegen golden data * Fix TC-DGGEN-1.1 * Fix removal of Commands.h * Fix YAML test --------- Co-authored-by: tennessee.carmelveilleux@gmail.com <tennessee@google.com> Co-authored-by: Restyled.io <commits@restyled.io> * Add orphan header files from `src/controller` to gn (#31882) * Add files from src/controller to gn * Add more orphaned files from controller itself * Restyle * Move more files into sources since CHIPCluster actually includes them. Seems VERY odd to have this header used but not actually have any implementation. This is a bug! * Attempt to fix some of the include oddities. Controller is VERY broken and feels like a god object definition * Move more headers ... CHIPDeviceController strongly pulls the entire world. * Fix typo * One more header * Fix chef * Add more includes that seem needed * Add another dependency * Add includes config to controller as it needs relative includes * Restyle * Fix clang-tidy logic * Apply some clang-tidy fixes since I looked at controller. Minor nullptr usage and remove else after return * Ensure no errors about unused assignments * Yet another fix for logic to make sure all defined lists are used * Include only headers as the special targets to force include errors * Fix typo * Fix typo --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * Add discover port parameter (#31948) * Adds MdnsDiscovery class (#31645) * Adds MdnsDiscovery class * Fix restyle/lint * Fix restyle * Adds zeroconf dependency in tests.yaml * Relocates zeroconf dependency from tests.yaml to requirements.txt * Addresses latest review comments * Fixes typo * Updates instantiation method and initial discovery * Fix restyle/lint * Addresses latest review comments * Addresses latest review comments * Fix restlye/lint * Addresses review comments * restore enum * Refactor progress * Major refactor to discover() and get_operational_service_info, pending other get methods * Fix restyle * Fix restyle/lint * Updates descriptions and variables * Major refactor #2 * Fix restyle * Updates method descriptions * Fix restyle * Addresses review comments * Fix restyle * Fix lint * Default parameters adjustment --------- Co-authored-by: C Freeman <cecille@google.com> * Allow chip-repl to know how many InvokeResponseMessages were recieved (#31781) * Allow chip-repl to know how many InvokeResponseMessages were recieved * Restyled by autopep8 * Clean up callback to be test only specifically * Restyled by clang-format * Address PR comments * Small edit to add line that shouldn't be removed in this PR * Address PR comment --------- Co-authored-by: Restyled.io <commits@restyled.io> * [ICD] Refactor ICDCounter logic (#31957) * Refactor ICD Check-In counter Fix initial Check-In counter value * Add basic integration tests to validate behavior * Restyled by whitespace * Restyled by prettier-yaml * rename source_set * Rename constant name * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * addres review comments * Add init/shutdown unit-test for the ICDManager * Fix Build.gn - multiple inclusion of CheckInMessage.cpp --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Add assertChipStackLockedByCurrentThread for LogEvent (#31895) * Updated test comments to display the proper keys values (#31968) * Move messagedef to its own buildfile (#31972) Co-authored-by: Andrei Litvin <andreilitvin@google.com> * Upload .ips bits in Xcode derived data on failure in Darwin tests as an artifact. (#31964) If there are crashes in the test, the crash logs should be in there, and we can try to debug those. * [Telink] Add B95 (TLSR9258A) skeleton & Update builds to docker version 35 (#31762) * add the board of tlsr9253b and tlsr9253b_retention * riscv: telink: update board setting - update the tlsr9253b setting . Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> * telink: b93: update the build sample and b93 platform - update the light-switch and lighting-app . - set the tlsr9253b and tlsr9253b_retention for the ci environment . Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> * telink: b93: fix the build environment - set the tlsr9253b and tlsr9253b_retention for the ci environment . Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> * telink: b93: loopback to remote version - change the github setting to telink . Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> * [Telink] Add B93 to Readme files * [Telink] Fix CI builds * [Telink] Reduce number of builds * [Telink] Disable update Zephyr to specific revision * Update builds to docker version 34 * [Telink] remove duplicated code * revert k32w image update * [Telink] rename B93 into B95 * Update builds to docker version 35 * fix doc build --------- Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> Co-authored-by: haiwen.xia <haiwen.xia@telink-semi.com> * Enforce that files in the `src` directory are referenced from BUILD.gn (#31960) * Start creating a script * Have much more functionality * Restyle * Add some doc comments ... this starts being usable * Add workflow to validate that gn knows about files * Remove controller from known exceptions: we fixed that one * Fix flake8 * Add more known failures * Better error reporting for gn reachability * Remove the platform specific orphan file listing * Force the "not failures anymore" to be fatal --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * Fix linter error: messagedef files are now covered by gn (#31995) * Rvc op state delegate dummy start stop handlers (#31764) * Added dummy implementations of the start and stop handler methods to the RvcOperationalState::Delegate class. * Removed the start and stop handler methods defined in the all-clusters-app RvcOperationalStateDelegate. * Removed the start and stop handler methods defined in the rvc-app RvcOperationalStateDelegate. * Restyled by clang-format * Apply typo fixes from code review Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com> * Rename EMBER_AF to MATTER_DM (#31971) * Mark ElectricalPowerMeasurement and PowerTopology provisional on Darwin. (#31959) * ubuntu:35 is not a valid runner (#32007) * Rearranged python test scripts order into an alphabetical format (#31930) * Rearranged order of the pytest scripts alphbetically accordingly to the arguments * Fixed 2 scripts alphabetically were not in line * This changes reflect the sorting of the testing python scripts via machine runned .py script. --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> * Fix global reference leak across the android in matter (#31890) * [ICD] Trigger Check-In messages at boot (#31993) * Send Check-In message at boot * Update reboot test * update comment * restyle * refactor function so that it can be used outside of the reboot * Remove unused define function --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> * TV Matter Media: Resolve cluster revisions (#31863) * Resolve the cluster revision issues * Restyled by whitespace * Restyled by clang-format * Update per comments * Restyled by whitespace * Restyled by clang-format * Update Content Launcher * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> * Linux: Implement PDC support in WiFiDriver / ConnectivityManagerImpl (#31983) * Use DecodeChipCert instead of LoadCert in chip-cert print-cert LoadCert performs additional checks (only relevant to operational certs) that prevent PDC identities from being printed. * Simplify CHIPCert test vector code * Add ConvertECDSAKeypairRawToDER to CHIPCert * Linux: Make WiFiNetwork struct private, add helpers - Make WiFiNetwork struct private - Move static_asserts to where the fields are defined - Add Empty() and Match() helpers to WiFiNetwork - Validate index parameter in ReorderNetwork() - Use CHIP_ERROR_FORMAT * Linux: Implement PDC support in WiFiDriver / ConnectivityManagerImpl * Address review comments * Clear handled err before the next call * [crypto] Extend the OperationalKeystore API to allow migration (#31279) - Extended the OperationalKeystore API by mechanism for migration of operational keys stored in one Operational Keystore implementation to another. - Extended the OperationalKeystore API by exporting keypair for Fabric. - Added Unit tests to PersistentStorageOpKeyStore and PSAOpKeystore regarding the new OperationalKeystore for migration and exporting OpKeys. Added first unit tests, created export method * Remove `CHIPClusters.h` and corresponding `.zapt` file from the build (#32004) * Completely remove all references to CHIPClusters.h * Restyle * Remove references to CHIPClusters.zapt as well * Use BaseCluster instead of specific clusters * Fix names and includes * add java and python files from `src/controller` to gn (#31977) * Add 2 java files to be known to gn * Add python files * Fix commas and format * Mark a set of files handled --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * Add files from `src/lib/dnssd` to be tracked by BUILD.gn files (#31976) * Make sure dnssd constants and browsedelegate is tracked by gn * Add more minmdns sources to be known to gn * Move more things into Types to make sure that platform Dnssd knows about them * Fix system layer dependency in linux dnssd impl * Remove dnssd files from lint * Add Delegate to Types as well ... it seems required for platform * Remove duplicate source * Restyle --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * Log when MTRServerAttribute not bound to a controller has its value updated. (#31973) This should enable API consumers to more easily figure out why their attribute updates are not being published. * Quick cleanup of unused type (#32009) * TV Matter Media: Add logic to message cluster (#31943) * Adding basic logic * Updates * Update message cluster * Update copyright * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> * Refactor CommandSender newly added APIs to be more extendable (#31837) * Update rvc app (#31827) * Replaced the vendor specific mode tag for the mapping mode with the mapping mode tag. * Updated the rvc-app's RvcOperationalStateDelegate to allow setting of a callback furtion for when the GoHome commond in received. * Implemented the GoHome handler for rvc-app. * Updated the PICS file for the rvc-app. * Fixed the Admin commissioning cluter's zap config for the rvc-app * Renamed the PICS values file to be similar to the ci file. Updated the script that runs all the RVC yaml tests. * Updated the rvc-app state machine diagram. * Updated theh rvc-app README. * Restyled by clang-format * Restyled by prettier-markdown * Restyled by shfmt * Updated the rvc-app .matter file. * Reduced the text of some errors as it was longer that allowed. * Added an out-of-band message to reset the rvc-app to its start-up state. * Updated a returend error following the spec change. * Excluded the RVC state diagram png from the lint check for %zu. * Updated the rvc-app readme. * Removed PIXIT settings from the rvc-app-pics values. * Excluded all binary files from the lint check for %zu. * Re-removed the OpenBasicCommissioningWindow command of the Administrator Commissioning cluster in the rvc-app due to security concerns. * Updated the rvc-app .matter file. --------- Co-authored-by: Restyled.io <commits@restyled.io> * TC-ACE-2.1/2: Add commissioning step (#31715) This is apparently what the TH is using to determine if a test requires commissioning, so we best add it. * Tweaks to evse test plans based on review(issue #31460) (#31901) * Added support for test event triggers and handling of reading events into matter_testing_support. * Made TC_EEVSE_Utils.py use the matter_testing_support instead of its own local copy. * Restyled by isort * Added TC_EEVSE_2_2, 2_4, 2_5 to tests.yaml. Fixed compile warning treated as error due to sign conversion. * Updated default min_charge and max_charge in TC_EEVSE_Utils send_enable_charge_command to have sensible default values if not specified. * Fixed test app name * Moved test runs later in test yaml * Fixed discriminator used in script to match that used in the app. * Added --endpoint 1 so it tests the correct endpoint * Code review comment fixes. * Fixed trailing whitepace * Merged TC_EEVSE tests back in --------- Co-authored-by: Restyled.io <commits@restyled.io> * Cleanup a few more files that were not recognized by gn (#31999) * Cleanup and fix some tests dependencies * Fix test compilation. Header was forcing C-linkage of the name * restyle * Fix code lint * Fix one more * Fix dependencies for more common integ files * Remove assert because this file is exercised in dependencies * Add Mock events handling * Remove TestOperationalDeviceProxy - this proxy does not seem to exist anymore and this test is never run * One more file update * Update linter * Restyle --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * [Darwin] MTRDevice cache make use of controller storage for persistent cache (#31952) * [Darwin] MTRDevice cache make use of controller storage for persistent cache --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Make MTRServerAttribute threadsafe. (#31970) * Make MTRServerAttribute threadsafe. If two API clients are both touching the same instance of MTRServerAttribute on different threads, we should handle that correctly. * Address review comments. * [Python] CommissonWithCode support discoveryType (#31904) * [Linux] fix memory leak * [Python] call StopDiscovery after DiscoveryNodes * [Python] CommissionWithCode support DiscoveryType * fix param error * add e2e test * automatically run in CI * Test different modes using different devices * fix error manual code * Microwave oven: Fix conformance (#32029) * [IM] Remove the EMBER_ZCL_STATUS_DUPLICATE_EXISTS error code (#32017) * Remove the EMBER_ZCL_STATUS_DUPLICATE_EXISTS error code * fix comments * [crypto] Add HKDF key handle and use it during PASE (#31311) * [crypto] Add HKDF key handle and use it during PASE Current SPAKE2+ interface assumes that raw shared secret is extracted and used by the application to derive session keys. This prevents using secure crypto APIs, such as PSA, to perform SPAKE2+ and do the key derivation in a secure environment, and isolate the application from key material. 1. Add Hkdf128KeyHandle type and add methods for deriving session keys from an HKDF key. 2. Change SPAKE2+ interface to return HKDF key handle instead of raw key secret. A similar approach can be taken to improve CASE security in the future though we would need 256-bit HKDF key support in such a case. * Change HKDF key handle to hold key of any length * Code review * Enable rvc python tests to run in ci (#31872) * Replaced the vendor specific mode tag for the mapping mode with the mapping mode tag. * Updated the rvc-app's RvcOperationalStateDelegate to allow setting of a callback furtion for when the GoHome commond in received. * Implemented the GoHome handler for rvc-app. * Updated the PICS file for the rvc-app. * Fixed the Admin commissioning cluter's zap config for the rvc-app * Renamed the PICS values file to be similar to the ci file. Updated the script that runs all the RVC yaml tests. * Updated the rvc-app state machine diagram. * Updated theh rvc-app README. * Restyled by clang-format * Restyled by prettier-markdown * Restyled by shfmt * Updated the rvc-app .matter file. * Reduced the text of some errors as it was longer that allowed. * Added an out-of-band message to reset the rvc-app to its start-up state. * Updated a returend error following the spec change. * Excluded the RVC state diagram png from the lint check for %zu. * Added the PICS_SDK_CI_ONLY PICS to the rvc-app-pics-values to allow it to run tests in CI. * Improved the TC_RVCCLEANM_2_1 test to allow the CI to run the tests against the rvc-app. * Improved the TC_RVCRUNM_2_1 test to allow the CI to run the tests against the rvc-app. * Improved the TC_RVCCLEAN_2_2 test to allow the CI to run the tests against the rvc-app. * Improved the TC_RVCRUNN_2_2 test to allow the CI to run the tests against the rvc-app. * Improved the TC_RVCOPSTATE_2_1 test to allow the CI to run the tests against the rvc-app. * Improved the TC_RVCOPSTATE_2_3 test to allow the CI to run the tests against the rvc-app. * Restyled by autopep8 * Restyled by isort * Updated the rvc-app readme. * Removed PIXIT settings from the rvc-app-pics values. * Excluded all binary files from the lint check for %zu. * Fixed typos from code review Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com> * Re-removed the OpenBasicCommissioningWindow command of the Administrator Commissioning cluster in the rvc-app due to security concerns. * Updated the rvc-app .matter file. * Removed sleeps between messages to the DUT as they are not needed. * Restyled by isort * Fixed extra imports in python tests. --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com> * Delete ContentLaunch::SupportedProtocolsBitmap::kWebRTC (#32042) Co-authored-by: Andrei Litvin <andreilitvin@google.com> * TC-SM-1.2: Use correct data type (#31644) * TC-SM-1.2: Use correct data type Credit to Manjunath for finding this. Fixes: https://github.com/project-chip/matter-test-scripts/issues/105 * one more fix * one more * Pull this out and add a test * linter * add docstring * Stop including af-enums.h in Darwin unit tests. (#32044) These are Objective-C files, and should not be including potentially-C++ headers. A bunch of "test that the code is 0" checks were replaced with "error is nil" checks (and some were removed, if "error is nil" was already being tested). The macro definition reformatting in MTRBackwardsCompatTests.m is just from updates to our clang-format version, looks like. * Add some more progress-style logging to Darwin server endpoints. (#32047) Lets us track when endpoints/clusters/attributes are set up and attribute values changed. * Remove include InteractionModelEngine.h in reporting/Engine.h (#32027) * [ICD] Add OperatingMode attribute to the LIT-ICD-app (#31997) * [Interaction Model]Sync AmberAfStatus to InteractionModel::Status (#32016) * Sync AmberAfStatus to InteractionModel::Status * fix comments * fix darwin build * add TODO for enum class * fix Darwin * tracing: Added a macro to report the metric values from the sdk to the tracing framework. (#32032) * Added metric support * Addressed the review comments * [CI] When the CI is starting the server (chip-tool or darwin-framework-tool) wait to see for the websocket message ready before trying to connect (#32006) * [darwin-framework-tool] Do not use platform::LogV since this is a no-op now * [CI] When the CI is starting the server (chip-tool or darwin-framework-tool) wait to see for the websocket message ready before trying to connect * [TC-MWOxxx] Add MWO tests (#30856) This PR adds test for the MWO clusters. - Test for Microwave Oven Mode cluster - Test for Microwave Oven Control cluster Note: tests reflect spec [PR 8588](https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8588) and [PR 8715](https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8715) This PR also: - Adds a CI build target for the microwave oven example app - Adds the python tests to CI - Uses the example app for tests instead of all-clusters - Fixes an SDK build problem for the microwave control cluster * Bump third_party/ot-br-posix/repo from `9326cc3` to `c5a7a35` (#32069) Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `9326cc3` to `c5a7a35`. - [Release notes](https://github.com/openthread/ot-br-posix/releases) - [Commits](https://github.com/openthread/ot-br-posix/compare/9326cc38b6b6ce81958a96d7821c4cb21976d636...c5a7a35e3bd2f3da8cce1e2e2a3bbe5cdeedb729) --- updated-dependencies: - dependency-name: third_party/ot-br-posix/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Wandalen/wretry.action from 1.3.0 to 1.4.4 (#32063) Bumps [Wandalen/wretry.action](https://github.com/wandalen/wretry.action) from 1.3.0 to 1.4.4. - [Release notes](https://github.com/wandalen/wretry.action/releases) - [Commits](https://github.com/wandalen/wretry.action/compare/v1.3.0...v1.4.4) --- updated-dependencies: - dependency-name: Wandalen/wretry.action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [placeholder] Remove tests generated with zap (#32038) * [placeholder] Remove examples/placeholder tests codegen * Remove src/app/tests/suites/pics * Remove src/app/tests/suites/include * Remove src/app/tests/suites/templates * Remove src/app/tests/suites/commands/[delay|discovery|log|system] * Remove examples/darwin-framework-tool/commands/tests/TestCommandBridge.h * [TI] CC2674 migration OTA support (#32026) * ota support for cc2674 * Restyled by clang-format * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io> * Update src/app/util/ emberafstatus (#32054) * 31599 DEMM & EVSEM FeatureMap list has to be updated as per test plan (should be 0) (#32057) * Fixes: #31599 - Changed to remove kOnOff support in EEVSEM and DEMM clusters. * Added a kNoFeatures enum to eevse and demm xml, and then regen_all * Revert "Fixes: #31599 - Changed to remove kOnOff support in EEVSEM and DEMM clusters." This reverts commit b79eec63fb35508772f852e5e402147de17df5fb. * Fix threadsafety issue in MTRServerAttribute. (#32084) An attempt to get the description could race with updates of _parentCluster. * Add Electrical power measurement to energy management app (#31616) * Hoist shared enums and bitmaps into detail namespace * Regenerate * Add electrical measurement clusters * Add NumberOfMeasurements attribute * Bump to latest spec * Bump ZAP version * Remove Electrical Measurement cluster * Add initial Electrical Power Measurement cluster implementation * Revert "Remove Electrical Measurement cluster" This reverts commit 47f5298ad6d1ed5f18b3ae3768960adbf604965c. * Fix incorrect min/max values on energy attributes * Formatting electrical-power-measurement-server * Regen after restoring deprecated electrical measurement cluster * Re-add inexplicably important blank line to zap_execution.py * De-alphabetize list of files to avoid breaking GH action * Semi-realphabetize? * Added EPM cluster to Energy Management App * Restore strangely dropped events * Better BitMask handling * Change min/max on electrical measurements to be decimal instead of hex * Rename meas-and-sense to measurement-and-sensing.xml * Remove seemingly superfluous attribute requirements on Descriptor cluster on Electrical Measurement * Updates to electrical-power-measurement-server based on comments * Take all-clusters-zap from upstream-master. * Added side=server into electrical-power and electrical-energy clusters XML so events can be enabled in ZAP * Updated all-clusters.zap and reran autogen. Added EPM cluster to energy-management-app.zap * Added initial version of EPM delegate and instance to energy-management-app * Enabled Electrical Energy Measurement in example-energy-management-app ZAP and regen all. * Added ElectricalEnergyMeasurement to chip-repl __init__.py * Restyled by isort * Changed feature map to indicate CUME and IMP support only * Adding into __all__ some missing clusters which are causing flake8 issues. * Removed out of date comment * Added a test event trigger to fake energy reporting readings into the EEM cluster (hooks ready for EPM cluster) * Added new Energy Reporting TE Trigger delegate * Updated random calculation and scaled into mWh (divide by 3600) * Restyled by whitespace * Restyled by gn * Removed accidental launch.json inclusion * Fix for ARM linux etc builds due to gn dependency check error * Added code review suggestions. * More code review suggestions fixed. * Hoist shared enums and bitmaps into detail namespace * Regenerate * Add electrical measurement clusters * Add NumberOfMeasurements attribute * Bump to latest spec * Bump ZAP version * Remove Electrical Measurement cluster * Add initial Electrical Power Measurement cluster implementation * Revert "Remove Electrical Measurement cluster" This reverts commit 47f5298ad6d1ed5f18b3ae3768960adbf604965c. * Fix incorrect min/max values on energy attributes * Formatting electrical-power-measurement-server * Regen after restoring deprecated electrical measurement cluster * Re-add inexplicably important blank line to zap_execution.py * De-alphabetize list of files to avoid breaking GH action * Semi-realphabetize? * Restore strangely dropped events * Better BitMask handling * Change min/max on electrical measurements to be decimal instead of hex * Rename meas-and-sense to measurement-and-sensing.xml * Remove seemingly superfluous attribute requirements on Descriptor cluster on Electrical Measurement * Updates to electrical-power-measurement-server based on comments * Remove defaults from MeasurementAccuracyRangeStruct to match spec update * Restore side="server" to events * Move common enums and bitmaps to detail:: instead of detail::Enums and detail::Bitmaps; remove superfluous using statement * Assign ID to Electrical Sensor device type * Removed EPM and EEM from Root Node Device * Restyled formatting is different than clang-format * Re-add FeatureMap to attributeAccessInterfaceAttributes for EEM and EPM * Regen after merge * Added electrical-energy-measurement-server to CMakelist to fix linker issue. * Lock client on Electrical Sensor device type * Remove unneeded using statement now that Enums are in detail:: * Check for null iterators and error * Switch to ResourceExhausted from CHIP_ERROR_INTERNAL * Re-enabled EEM in energy management app and regen all after previous merge * Some refactoring to add EPM Instance into the EVSEManufacturer class to clean up containment. Added ability to fake voltage, power and current to the TE triggers. * Missed one file. * Fixed crash due to unassigned dg pointer. Power/Voltage/Current faking working too. * Touch file since restyled crashed * Restyled by gn * Restyled by isort * Add stub for EPM cluster * Reverted whitespace change * Did regen_all after merge from master to resolve conflicts. * Put back line of clusters which somehow got deleted accidentally. * Remerged ZAP file and regen all after resolving conflicts. * Fixes for Python tests * Correct name for Ember init callback * Formatting * Sync optional attributes list with .zap file for EPM * Add missing features to EPM stub * Revert FeatureMap in attributeAccessInterfaceAttributes * Allow FeatureMap in EEM constructor; add all-clusters-app EEM stub * Forgot zcl-with-test-extensions * Unregister EEM attribute access in destructor * Remove redundant returns to keep clang-tidy happy * Fix for issue mentioned in code review on EEM cluster limiting the number of endpoints it allows. * Refactoring to have a common EvseMain across all platforms to avoid making changes in multiple places * Added electrical-power-measurement-server to ESP32 CMakeLists.txt * Updated Matter device types to add EVSE * Open and saved energy-management-app.zap and regen_all * Removed duplicate ElectricalEnergyMeasurment class which was accidentally merged in. Fixed issue raised about ElectricalEnergyMeasurement array size not working on bridges. * Added support for test event triggers and handling of reading events into matter_testing_support. * Made TC_EEVSE_Utils.py use the matter_testing_support instead of its own local copy. * Restyled by isort * Cherry pick from Tweaks to EVSE Test plans (Issue #31460) * Changed the random value generation to make the values +/- and handle sign conversion to avoid compile warnings * Enabled cumulativeEnergyExported in Energy-management-app. * Added initial electrical power measurement 2.2 test case * Changed copyright date * Code review comment fixes. * Changed to c++ style cast * Fixed trailing whitepace * Added support for testing read of EEM attributes and change of values * Corrected EPM references in TC_EEM_2_2. Added TC_EEM_2_3 * Added periodic energy reporting, and new cumulativeEnergyReset attribute into energy-management-app.zap * Added periodic energy reading support and TC_EEM_2_3 to 2_5. * Python removed unused logging and EventChangeCallback * Updates to align to test plan PR #3949 * Added initial EEM_2_1 test script. * Added example of setting EEM Accuracy and EEM CumulativeEnergyReset structure - TC_EEM_2_1 now passes * Restyled by whitespace * Restyled * Removed extra spaces in TC_EEM_2_1.py * Removed unused EnergyManagementManager.cpp/.h * Fixed PowerMode = kAc * Initial TC_EPM_2_1.py script * Restyled by isort * Merged TC_EEVSE tests back in * Initialized NumberOfMeasurementTypes * Added EEM 2.1,2.2,2.3,2.4,2.5 and EPM 2.1,2.2 into CI workflow tests.yaml * Interim state - partially refactored how Measurement Structs are encoded similar to how ModeBase clusters are implemented. Needs tidy up. Will break all-clusters for now * Removed SetNumberOfMeasurementTypes since this can be derived from the ArraySize(kMeasurementAccuracies). Added more stringent checking in test script of measurementTypes and ranges. * Completed TC_EPM_2_1.py script * Corrected test plan spec reference. * Test EPM_2_1 now runs and passes. Allows checking that attributes are supported, and skips test if not. Validation of values ignores Nulls (which are allowed). Turned on Ranges attribute. * Revert unintended change to tests.yaml * Python test case code-review updates * Removed old range iterator. * Fixed lint issues and adjusted timings to match the test plan pr. * Fixed all-clusters electrical-power-measurement cluster by using the energy-management-app/common Delegate * Implemented HarmonicCurrents and HarmonicStructs (to return empty list for now) * Changed the API to ensure that a delegate doesn't change the data mid-way through a read, so the cluster server signals with a StartxxxRead and EndxxxRead call * Applying suggested changes * Incorporated feedback from review to simplify the code * Removed comment per code review --------- Co-authored-by: Hasty Granbery <hasty@granbery.org> Co-authored-by: Restyled.io <commits@restyled.io> * Darwin: Simplify test setup and teardown (#32061) * Darwin: Simplify test setup and teardown Avoid relying on dummy tests that are ordered first / last. * fix unused variables * Bump third_party/openthread/repo from `cf357d7` to `b212a0a` (#32067) Bumps [third_party/openthread/repo](https://github.com/openthread/openthread) from `cf357d7` to `b212a0a`. - [Release notes](https://github.com/openthread/openthread/releases) - [Commits](https://github.com/openthread/openthread/compare/cf357d70be94e6f3f21d07b3c16e29bb7ec5cc7e...b212a0a748070ccbda765c3ebed2aab8b6b08fce) --- updated-dependencies: - dependency-name: third_party/openthread/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump third_party/mbedtls/repo from `6b36a5d` to `ede909f` (#32066) Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `6b36a5d` to `ede909f`. - [Release notes](https://github.com/ARMmbed/mbedtls/releases) - [Commits](https://github.com/ARMmbed/mbedtls/compare/6b36a5db07ae0e299c9e67f526c28db93e586e25...ede909f99ab6e6a958a41e365251c2a1d2c4ed4d) --- updated-dependencies: - dependency-name: third_party/mbedtls/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump third_party/imgui/repo from `f50ddc4` to `5360903` (#32068) Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `f50ddc4` to `5360903`. - [Release notes](https://github.com/ocornut/imgui/releases) - [Commits](https://github.com/ocornut/imgui/compare/f50ddc431e3b8840036e88abc4c3cf74500aa12b...536090303a8fca7d896f77d6d63dc59249bc87f4) --- updated-dependencies: - dependency-name: third_party/imgui/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update chef.py (#32060) * DNS-SD: Remove calls to set T flag (#32083) * DNS-SD: Remove calls to set T flag Nothing currently supports TCP, therefore nothing should be setting this flag. Per the new spec text, it is now forbidden to have the lowest bit marked. This will bring the SDK examples into compliance with 1.3. Note that this PR does not fix the advertising parameters API. We will need a new API for this flag when TCP support lands. Leaving this for a follow up PR as changing the API should happen separately from bringing the examples into conformance as it may affect the platforms, who have implementations outside of the SDK. Test: tested with all-clusters and avahi. Also fixed tests to omit this flag and ensure it does not appear in the TXT record. Automated cert test for operational records is in progress and requires this PR to pass. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> * [nrfconnect] Fix memory leak in Window Covering sample. (#32041) We were leaking 8 bytes each time the new attribute change was reported by the WindowCovering Server. It was resulting in running out of heap when stressing the device (by sending multiple up-or-open/down-or-close commands). Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * [Silabs] Update Silabs ICD status LED functionality description within README.md's (#31888) * Updated Silabs ICD status LED functionality description * Restyled by prettier-markdown * Updated style and spelling * Updated style and spelling * Updated to include ICD vs. non-ICD LED behavior description * Removed unnecessary underscores * Correct description/documentation to refactored location of Silabs lighting example * Restyled by prettier-markdown * Restyled by shfmt --------- Co-authored-by: Restyled.io <commits@restyled.io> * Enabling wpa3 mode by default. (#31858) * Mark PayloadTestRequest/Response provisional on Darwin for now. (#32085) * [Examples] Remove EmberAfStatus from example files (#32056) * Replace EmberAfStatus in examples files * Fix Tv-app * fix ci * remove using in headers * [Android] Add Status handling for onReport code path (#32082) * [ICD]Convert the ICD DNS advertiser variable from optional bool to an enum class (#32080) * Convert the ICD DNS advertiser variable from optional bool to an enum class * Apply suggestions from code review Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> * default mICDModeAdvertise to kNone --------- Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> * Update DGGEN_1_1 and DGGEN_2_3 to match latest testplan spec (#31998) * Update DGGEN_1_1 and DGGEN_2_3 to match latest testplan spec * Fix CI * Fix CI * Restyled by whitespace * Restyled by prettier-yaml * Fix CI * Fix CI * Quick fix * Update based on PR comments * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io> * Add test steps to IDM_1_4 to validate multiple InvokeResponseMessages (#31979) * Add test steps to IDM_1_4 to validate multiple InvokeResponseMessages * Restyled by autopep8 * Address PR comments and CI issues * rename variable * Fix CI * Fix incorrect merge attempt * Fix CI --------- Co-authored-by: Restyled.io <commits@restyled.io> * [Tizen] Shink scope of `capi-system-peripheral-io` dep (#32048) * [Diagnostic Logs] Followup for #31638 (#31833) * [CI] Make it possible to specify the timeout when waiting for a specific string in scripts/tests/chiptest/test_definition.py since it may be longer than 10 seconds * [CI] Add a second instance of the configured applications such that YAML can start the app multiple times if needed * [BDX:DiagnosticLog] Update the server such that it supports multiple downloads in parallel * [darwin-framework-tool] Address post-landing comments of #31638 [CI] Add some tests for bdx download with darwin-framework-tool * Use `include-what-you-use` on lib/core (#32046) * A first pass at running IWYU with some manual fixes * Refert platform file changes * Move one header up due to self-review * Move self-header to top of file * Another pass this time with -Xiwyu flags * Start adding a IWYU mapping so we need less manual fixes * Fix command line * Update iwyu.imp * Remove forward decl * Fix for compile * Fixes to compile locally ... several things could be cleaned * One more cleanup, linux all-clusters compiles at least --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> * DM XMLs: 1.3 0.7 recirculation ballot (#31980) * DM XML: Scrape from 1.3 0.7 recrirculation ballot * Manual fixes for aliased clusters (pending 1.2.4 fix in scraper) * Manual fix for base device type This broke again when I re-levelled the section headers. Will fix in spec. * Update API maturity where missing on 1.3 clusters (#32101) - API maturity was not set properly on some clusters - API maturity is being updated to provisional for new clusters Fixes #32099 Testing done: - Non functional change * [IM] Remove EmberAfStatus from src/app/clusters (#32055) * Remove EmberAfStatus from src/app/clusters * fix ci * fix specs compliance * remove using Status from headers * fix comments * Remove using Status from headers * fix comments * fix ci * fix door lock * Skip binary files when checking for code patterns in the lint test. (#32102) * [NXP][K32W] k32w1 sdk 2.12.6 updates & k32w0 small fixes (#31924) * [common] Remove k32w1 device_platform, use nxp instead Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Build, OTA, Diagnostic changes Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> Signed-off-by: Marius Tache <marius.tache@nxp.com> Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W1] Rename SNT files to ELEMU * [K32W] Add OPENTHREAD_PLATFORM_CORE_CONFIG_FILE define Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Fix MBEDTLS build flags conflict between Matter vs. OpenThread Matter uses a multithread flavor of MBEDTLS while OpenThread uses a single thread flavor. This triggers a dangerous situation where Matter, OpenThread and MBEDTLS don't agree on the size of various data structures exchanged through the interface which later leads to memory access violations. This update fixes the build configuration so that OpenThread also uses the multithread flavor of MBEDTLS. Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [NXP] Update ot-nxp commit-id Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W0] Add necessary check for env variable When computing the path for the signing script, the existence of env variable NXP_K32W0_SDK_ROOT should be checked first to avoid issues. Signed-off-by: marius-alex-tache <marius.tache@nxp.com> * [K32W1] Remove ResetWatermarks empty implementation Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Set rotating device id unique id length to max by default Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Fix an issue with __wrap_realloc Current memory manager is MML, which has realloc support. Removed old function that was relevant only in FreeRTOS memory manager (heap4/5) context. Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Accomodate low power API update PWR_AllowDeviceToSleep/PWR_DisallowDeviceToSleep API reintroduced in SDK. power.c removed from ot-nxp. Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Clear keys from counter area when factory resetting Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Use MML API for heap memory consumption statistics WTRMRK feature of the Software Diagnostic Cluster will be implemented once the memory manager will implement the needed API. Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Remove duplicated code in crypto PAL P256Keypair members were moved into protected scope, so derived classes (P256KeypairSSS) can access these members. Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Call PLATFORM_InitTimerManager before PLATFORM_InitBLE since this function won't be initializing the timer manager anymore * [K32W1] Post events from ISR correctly Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] MML realloc should be protected from task switching Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Add initial FactoryDataProviderImpl Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Update certification declaration in apps Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Update README files in apps Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Add DAC private key convert declaration TBD Signed-off-by: Marius Tache <marius.tache@nxp.com> * [k32w1] Fix usage of deprecated factory data provider fields Signed-off-by: marius-alex-tache <marius.tache@nxp.com> * [COMMON] Add dac_key_use_sss_blob option dac_key_use_sss_blob can be used to select which data the private key area stores: plaintext/encrypted private key or an SSS exported blob. The option is False by default. Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Add SSS API usage Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Add chip_convert_dac_private_key option chip_convert_dac_private_key can be used to enable one-time-only conversion of the DAC private key to an SSS encrypted blob. Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Add jlink conversion script example Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Update readme to point to docs guide Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Remove unused mbedtls modules Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Factory data section should only be reserved in factory data context Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Add destructor to free SSS object context Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Add verbose logging for conversion steps Signed-off-by: Marius Tache <marius.tache@nxp.com> * [K32W1] Restore NVM sector number The underlying issue, for which the increase in NVM sectors was a workaround, was solved. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W1] Add BLE ResetController function Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W1] Allocate OT buffers from SMU2 When using use_smu2_dynamic=true, OpenThread buffers will be allocated from a 13KB SMU2 region after a successful commissioning process until a factory reset is done. * Add SMU2 namespace in SMU2Manager.h/.cpp * Add build changes * Add allocator changes * Add necessary OpenThread config defines * Add gn parameter/defines for each SMU2 usecase Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W1] Offload SHA256 operations to S200 * Offload simple sha256, simple hmac sha256, update/finish sha256, update/finish hmac sha256 from Matter and OT. * Implement solution for long sha256 that uses context save/export/restore mechanism. This solution saves the intermediate data on heap and computes the hash on demand (by calling GetDigest). * Put changes under define/gn parameter use_hw_sha256 as they increase timings (due to hardware accelerator initialization time) and use a significant amount of heap. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W1] Simplify HW DRBG/TRNG usage S200 TRNG is already used though otPlatEntropyGet from OT. Simplify Matter and OT DRBG usage of HW TRNG by not using mbedtls entropy. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W1] Offload AES operations to S200 * Offload AES-CCM from Matter. * Offload AES-ECB from OT. * Use software AES-CCM when Additional authentical data len is zero. * Put changes under define/gn parameter use_hw_aes as they increase timings (due to hardware accelerator initialization time). Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [K32W1] Fix duplicated flag Signed-off-by: Marius Tache <marius.tache@nxp.com> * [COMMON] Add pw RPC support The pw RPC integration should be usable by all NXP platforms that support SerialManager, since the pw_sys_io backend uses streamer_nxp.cpp for serial communication. A scope is defined in pw_rpc_server.gni to be used by all apps by forwarding the variables in the application executable scope: forward_variables_from(pw_rpc_server, "*") Logging and RPC communication share the same serial port. Logging should be inspected in chip-console, which manages the HDLC channels. Signed-off-by: Marius Tache <marius.tache@nxp.com> * [COMMON] Update streamer to read RX data ASAP Moved reading the RX FIFO inside the actual interrupt handler, to avoid time penalty when notifying the consumer task (RPC/App CLI). The data is instead stored in a cache buffer and read once the task is unblocked through notifying by the …

* Rerouted tracing macros to Darwin signposts * Initial framework for logging scalar data event * Handled the new metrics event changes in collector * Modified VerifyOrExit macro to accept an optional metric key as third argument * Removed direct use of chrono in metrics_event.h Switched MTRMetrics to vend dictionary for metric keys * Modified SuccessOrExit to optionally accept metric key * Moved metric keys to separate header Reworked metric_event names for more clarity * Switched MATTER_TRACE_METRIC usage to MATTER_LOG_METRIC * Restyle fixes * Fixed unit tests * Fixed build failure due to MetricEvent hidden inside tracing enabled * Fixing one source of build error * Fixing darwin build failure * Code Review: Rename LogMetric to LogMetricEvent * Code Review Suggestions: 1. Metric Macros take full string constants and no longer use preprocessor to prefix. Allows free flowing strings 2. Reworked MetricEvent class and documented 3. Handled LogEventMetric for Darwin, ESP32, Perfetto, JSON to account for all types 4. Removed timePoint from MetricEvent class. Timestamps and duration calculation is now responsibility for the handlers of the event 5. Reverted BUILD.gn in system to not break out SystemClock.h * Code Review Feedback #2: 1. Added SuccessOrExitWithMetric and VerifyOrExitWithMetric 2. Cleaned up support .gn to remove dependedency on metrics * Code Review Feedback #3: 1. Added ScopedMetricEvent to use RAII to track begin and end within a scope * Code Review project-chip#4: Reverted an accidental removal * Added MTRMetricData to description as per review comment * Restyler fixes * Sample code of how Begin and End log metrics can be used * Fixed compilation error when tracing is disabled * Fixes for build failures when tracing is disabled * Picked up code review suggestion accidently dropped * Code Review Feedback: 1. Begin metric does not take value 2. Allow undefined value for metric 3. Misc other feedback * Handle undefined value and error value * Revert a comment change * Review Feedback: Changed ScopedMetricEvent to capture error by reference * Fixed another build failure * Reverting usage of LOG_METRICS * Review feedback: Fix incorrect documentation * Code Review Feedback: Remove access to Value in MetricEvent to avoid incorrect access * Restyler fixes * Unregistering backend in Darwin shutdown * Resytler fixes...

…ct-chip#33112) * pw_unit_test migration: setup_payload batch #2 (with fixtures) * restyle fix * integrating comments * restyle * Update test_components_nl.txt --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>

sharadb-amazon and others added 30 commits May 25, 2023 12:57

tv-casting-app: turning off extended discovery (#26804)

76ccf9d

* tv-casting-app: turning off extended discovery (#170) * Moving mTimeSource declaration behind CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY

[ESP32] Kconfig fixes and link error fix for h2 (#26825)

35d40cc

* [ESP32] Do not select factory data provider and device instance info provider when secure cert dac provider is selected * Fix the linker error when building for esp32h2 * Move ieee802154 under openthread config

[ESP32] Fix generation of encrypted factory partition (#26840)

49e36af

Update silabs lighting zap files. Set some Colorcontrol attributes … (#…

37003a3

…26853) * Update silabs lighting zap configs. Set some Colorcontrol attributes to NVM to match spec * Also set startUpColorTemperatureMireds to NVM storage

Add a lint for SuccessOrExit without assignment. (#26854)

ad5253a

* Add a lint for SuccessOrExit without assignment. This is almost always a mistake, since it loses track of the error involved. * Address review comment.

Add support for implementing different ethernet boards for esp32 (#26687

fd333d1

)

[matter_yamltests] Allow endpoint, cluster, command, attribute, event…

b1a373b

… to use a variable (#26678)

Add ways to construct cluster structs from the shared superclass. (#2…

19ae369

…6763) * Add ways to construct cluster structs from the shared superclass. This is only relevant when a struct is being shared across multiple clusters. * Address review comment.

[matter_yamltests] Increase the keep alive timeout for websockets (#2…

2b4eec0

…6870)

[matter_yamltests] Replace python 3.9 list/tuple syntax with typing.L…

3029f04

…ist/typing.Tuple (#26873)

change OptionalQRCodeInfo to data class (#26849)

8f16fe9

Fix Java header generation for attributes with nullable list type. (#…

a63cc4f

…26880)

Improve documentation for the "value" of an MTREventReport. (#26856)

2e0aab6

fix for DIC TLS connection when MBEDTLS_USE_PSA_CRYPTO is enabled (#2…

7e6eb8b

…6876)

Fix network commissioning setup for linux lighting-app. (#26904)

aa947c1

marktrayer merged commit 47b3846 into marktrayer:opstateyaml May 31, 2023
56 of 57 checks passed

github-actions bot added app config controller darwin documentation Improvements or additions to documentation esp32 examples github gn inet lib linux platform scripts shell support telink tests tools workflows core crypto setup payload labels May 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fast forward master into dev branch #2

Fast forward master into dev branch #2

marktrayer commented May 31, 2023

Fast forward master into dev branch #2

Fast forward master into dev branch #2

Conversation

marktrayer commented May 31, 2023