-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: turning off extended discovery #26804
Merged
sharadb-amazon
merged 2 commits into
project-chip:master
from
sharadb-amazon:extdisc-20230524
May 25, 2023
Merged
tv-casting-app: turning off extended discovery #26804
sharadb-amazon
merged 2 commits into
project-chip:master
from
sharadb-amazon:extdisc-20230524
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
May 24, 2023 17:23
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 24, 2023 17:23
sharadb-amazon
changed the title
tv-casting-app: turning off extended discovery (#170)
tv-casting-app: turning off extended discovery
May 24, 2023
PR #26804: Size comparison from bf95967 to ed487d3 Increases (13 builds for bl602, bl702, psoc6, telink)
Decreases (9 builds for efr32, esp32, linux, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
extdisc-20230524
branch
from
May 24, 2023 21:07
ed487d3
to
b083550
Compare
andy31415
approved these changes
May 24, 2023
PR #26804: Size comparison from 6ce2412 to b083550 Increases (7 builds for bl602, cc32xx, telink)
Decreases (11 builds for bl602, bl702, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26803
Problem
The tv-casting-app had extended discovery turned on, which meant it would advertise commissionable node even when it is not going through the commissioning process.
Change summary
Set CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY to 0, which means the tv-casting-app will not only advertise commissionable node when the commissioning window is opened.
Testing
Tested using the Android and iOS tv-casting-apps and ensured they do not advertise commissionable node on startup any more. And that they can still be commissioned with the tv-app.