Apple silicon plus x264 commit #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs newer code in some cases, and some conditionals to check platform. The external patches possibly should be brought in? Seems to work for now if anyone is in need. Learnings from https://github.com/ssut/ffmpeg-on-apple-silicon
* Define M1 variable once * Grab x264 archive vs git * configure vs Configure * bonus: output binary type. Feel free to take or leave :)
branched from "apple_silicon" branch.
|
Great, all checks have passed. I create a new pre-release of the script tomorrow, which will include your patches and the new additional library libsvtav1. Afterward, It would be good if you can verify that ffmpeg still builds on an m1 mac. |
|
Will do; always happy to help!
…On Tue, Jan 19, 2021 at 4:34 PM markus-perl ***@***.***> wrote:
Great, all checks have passed. I create a new pre-release of the script
tomorrow, which will include your patches and the new additional library
libsvtav1. Afterward, It would be good if you can verify that ffmpeg still
builds on an m1 mac.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJBAYQVS53VANAPY3FH3DLS2YCGZANCNFSM4WJGFMVQ>
.
|
|
I've merged all outstanding changes into the master branch. Tests passed :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same changes as apple_silicon branch but switched to the x264 commit to see if it passes PR testing.