fix nil pointer dereference for valid demo #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#138c28)DeepCode analyzed this pull request. |
markus-wa
force-pushed
the
issue/162-nil-dereference-november19-update
branch
from
8282378
to
d70a67c
Compare
golangcibot
reviewed
Nov 23, 2019
markus-wa
force-pushed
the
issue/162-nil-dereference-november19-update
branch
from
d70a67c
to
4c8b109
Compare
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
+ Coverage 91.53% 91.8% +0.26%
=========================================
Files 29 29
Lines 2493 2501 +8
=========================================
+ Hits 2282 2296 +14
+ Misses 158 152 -6
Partials 53 53
Continue to review full report at Codecov.
|
markus-wa
force-pushed
the
issue/162-nil-dereference-november19-update
branch
from
4c8b109
to
bc4bf26
Compare
golangcibot
reviewed
Nov 28, 2019
we just assume it's a bot since all human players were parsed correctly in the demo where this problem was encountered.
markus-wa
force-pushed
the
issue/162-nil-dereference-november19-update
branch
from
bc4bf26
to
138c28f
Compare
|
Code Climate has analyzed commit 138c28f and detected 0 issues on this pull request. View more on Code Climate. |
markus-wa
changed the title
xavier-rodet
pushed a commit
to xavier-rodet/demoinfocs-golang
that referenced
this pull request
Dec 1, 2019
…#163) we just assume it's a bot since all human players were parsed correctly in the demo where this problem was encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #162
We just assume the player which cannot be found is a bot and skip it, since all human players were parsed correctly in the demo where this problem was encountered.