Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: add TeamClanNameUpdated #443

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

micvbang
Copy link
Contributor

This PR adds an event for tracking whenever a team's clan name has been updated. In my experience this has been extremely useful when tracking team-related changes made by certain server bots.

@micvbang micvbang force-pushed the micvbang/event-team-clan-name branch 2 times, most recently from 580138d to f1efbae Compare October 15, 2023 15:10
@akiver
Copy link
Collaborator

akiver commented Oct 15, 2023

Hi, and thank you!

The last step to fix the CI would be to update the goldenfile as described here.
Let me know if you need help, thank you.

@micvbang micvbang force-pushed the micvbang/event-team-clan-name branch from f1efbae to 34f697d Compare October 15, 2023 16:15
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c3dd59f) 80.15% compared to head (4b273ea) 80.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   80.15%   80.25%   +0.09%     
==========================================
  Files          47       47              
  Lines        6199     6209      +10     
==========================================
+ Hits         4969     4983      +14     
+ Misses       1022     1018       -4     
  Partials      208      208              
Files Coverage Δ
pkg/demoinfocs/datatables.go 91.73% <100.00%> (+0.09%) ⬆️
pkg/demoinfocs/events/events.go 78.57% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micvbang
Copy link
Contributor Author

Thank you! That should be done now 😊

@micvbang micvbang force-pushed the micvbang/event-team-clan-name branch from 46d68ec to 4b273ea Compare October 15, 2023 17:37
@akiver akiver merged commit 0309a57 into markus-wa:master Oct 15, 2023
5 checks passed
@micvbang micvbang deleted the micvbang/event-team-clan-name branch October 15, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants