Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bomb planter not found #464

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: bomb planter not found #464

merged 2 commits into from
Nov 1, 2023

Conversation

akiver
Copy link
Collaborator

@akiver akiver commented Nov 1, 2023

fix #461

For some reason at tick 0 a CPlantedC4 entity is created but players are spawning and the bomb is not planted.

Also update the rank type values in the comment.

@akiver akiver requested a review from markus-wa November 1, 2023 10:43
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8bf8a71) 80.38% compared to head (e643d84) 80.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   80.38%   80.36%   -0.03%     
==========================================
  Files          47       47              
  Lines        6257     6259       +2     
==========================================
  Hits         5030     5030              
- Misses       1018     1019       +1     
- Partials      209      210       +1     
Files Coverage Δ
pkg/demoinfocs/common/player.go 63.00% <ø> (ø)
pkg/demoinfocs/datatables.go 91.82% <33.33%> (-0.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markus-wa markus-wa merged commit 60ef60a into master Nov 1, 2023
6 of 8 checks passed
@markus-wa markus-wa deleted the fix-planter branch November 1, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime error: invalid memory address or nil pointer dereference
2 participants