fix: users not found in game events with new demos #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 80.51% 80.53% +0.01%
==========================================
Files 47 47
Lines 6292 6298 +6
==========================================
+ Hits 5066 5072 +6
Misses 1017 1017
Partials 209 209 ☔ View full report in Codecov by Sentry. |
Otherwise the player may be the GOTV entity in case of damages/kill by the "world".
akiver
commented
Nov 18, 2023
| @@ -119,7 +119,17 @@ func (geh gameEventHandler) gameState() *gameState { | |||
| } | |||
|
|
|||
| func (geh gameEventHandler) playerByUserID(userID int) *common.Player { | |||
| return geh.gameState().playersByUserID[userID] | |||
| player := geh.gameState().playersByUserID[userID] | |||
| if player != nil || !geh.parser.isSource2() { | |||
There was a problem hiding this comment.
I don't change it for Source 1 demos because in case of damages/kills done by the "world" it would return the GOTV entity (id 0) instead of nil.
In Source 2 the CSTV entity ID is not always 0 and may have SourceTV or DemoAutoRecorder as a name.
markus-wa
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last update, game events contain "user slot" rather than "user id" that come from the userinfo table.
Tested on a bunch of valve and faceit demos.
fix #476