Added support for custom line number generation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UbadahJ May I ask what the use case is that you needed this functionality for? I assume that the default implementation in this PR works the same as the previous one, so I can safely merge without breaking changes? |
|
The default implementation is same as before just in the form of a generator As for the use case, it may be used for localization but in my case, I used it remove the postfix from line numbers |
|
Interesting! Thx again for your work, will merge! 🤓 |
|
Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Loved your project and decided to use it in my personal project but there was a little feature missing from it which was custom lines support. So forked it and added a property to allow changing this behavior. If the code up to par or the feature is not unnecessary, you can merge it.