Fixed linenumbers #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addition of CodeEditorLayout as a managing tool for child views (line numbers, divider, edittext)
# Conflicts: # library/src/main/java/de/markusressel/kodeeditor/library/view/CodeEditorView.kt
added attribute for maxZoom to cev xml (passing properties to child views would be better but I don't know if and how that would be possible yet) wrapped linenumber TextView in a ZoomLayout synchronized zoom and pan of linenumber ZoomLayout and actual editor ZoomLayout disabled "moveWithCursor" for now, as it only causes problems
explicitly dont't show scrollbars on linenumber view
refactoring and cleanup fixed issues with linenumber scaling and pan
CodeEditText: clear old highlighting before changing syntax highlighter use @jvmoverloads
added CodeTextView for static text with syntax highlighting support
remove unused code
linenumber size fix
added fuel http networking library retrieve latest README content from GitHub instead of hardcoding it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4