Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change suggested func in 'did you mean to use' warning #66

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

ChrisMuir
Copy link
Collaborator

Updated the suggested function names passed as args to listwarning(). Here's an example:

stringdist::stringdist(list(55, 56), c(67, 56))

Output is this:

[1] 2 0
Warning message:
In stringdist::stringdist(list(55, 56), c(67, 56)) : 
You are passing one or more arguments of type 'list' to
'stringdist'. These arguments will be converted with 'as.character'
which is likeley not to give what you want (did you mean to use 'seqdist'?).
This warning can be avoided by explicitly converting the argument(s).

seqdist() is not an exported function, but seq_dist() is. This PR changes the suggested function to be seq_dist (same with stringdistmatrix(), the suggested function name passed to listwarning() was edited to be seq_distmatrix).

@coveralls
Copy link

coveralls commented Mar 31, 2018

Coverage Status

Coverage remained the same at 90.438% when pulling 7a49711 on ChrisMuir:master into f530d7f on markvanderloo:master.

@markvanderloo markvanderloo merged commit 2123513 into markvanderloo:master Apr 1, 2018
@markvanderloo
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants