updated for keras 2.2+, tf2 #12
Conversation
|
I've added some very basic tests here, modernized the package metadata/installation, and set up github actions for CI testing and publishing. The actions should take effect when this merges. I'll hold off on a torch implementation for a separate PR, as that will require a bit more thought about API. Otherwise I think this is good to merge. |
| python -m pip install autopool[keras] | ||
| ``` | ||
| For the tensorflow implementation: | ||
| ``` | ||
| python -m pip install autopool[tf] |
There was a problem hiding this comment.
What happens if you call pip install autopool withtout the keras/tf specification? Is there a default behavior?
There was a problem hiding this comment.
It installs with no dependencies. We actually have no (runtime) dependencies beyond the python core until getting into specific framework implementations.
| pip install -u autopool | ||
|
|
||
| to install just for your own user. | ||
| python -m pip install autopool[tf] |
There was a problem hiding this comment.
cf prev comment, what happens if pip install autopool ?
|
|
||
|
|
||
| class AutoPool1D(Layer): | ||
| '''Automatically tuned soft-max pooling. (tensorflow.keras implementation) |
There was a problem hiding this comment.
tensorflow.keras implementation?
There was a problem hiding this comment.
Yes, as opposed to the keras implementation, or a low-level tensorflow implementation (Does not exist)
This PR updates autopool to work with keras >= 2.2 and/or tensorflow 2.0
I'm also rolling in some restructuring as noted in #13 and some general package maintenance as needed.