Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usual cursor shortcuts don't work in history/completion menu #411

Closed
marlonrichert opened this issue Jan 21, 2022 Discussed in #409 · 2 comments
Closed

Usual cursor shortcuts don't work in history/completion menu #411

marlonrichert opened this issue Jan 21, 2022 Discussed in #409 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@marlonrichert
Copy link
Owner

Discussed in #409

Originally posted by saul January 21, 2022
Hi

When in the history prompt, when I try to use Home/End, they do nothing. Similarly using Ctrl-Left/Ctrl-Right does not move backward/forward a word - they act as PgUp and PgDown and navigate the history menu instead.

I noticed in the README that:

most other keys | Accept selection, then perform usual action

Do I need to manually setup these keybindings? What am I doing wrong?

@marlonrichert marlonrichert added the bug Something isn't working label Jan 21, 2022
@marlonrichert
Copy link
Owner Author

@saul You are not doing anything wrong! That is, in fact, a bug. Thank you for reporting. I will fix it. 🙂

@marlonrichert marlonrichert self-assigned this Jan 21, 2022
@marlonrichert marlonrichert changed the title Usual navigation keys don't work in history menu Usual cursor keys don't work in history/completion menu Jan 21, 2022
@marlonrichert marlonrichert changed the title Usual cursor keys don't work in history/completion menu Usual cursor shortcuts don't work in history/completion menu Jan 21, 2022
@marlonrichert marlonrichert added the good first issue Good for newcomers label Sep 8, 2022
@marlonrichert marlonrichert removed their assignment Sep 27, 2022
@marlonrichert marlonrichert added the help wanted Extra attention is needed label Sep 27, 2022
@marlonrichert
Copy link
Owner Author

Turns out this is a bit more work than I initially anticipated. What needs to be done is to find all keys bound to widgets that are special to zsh/complist (except the ones we actually want to be special) and then rebind them to the same widget, but prefixed with a .. This is not complex; it just requires some manual labor and testing (for which I personally haven't the time yet). Pull requests welcome! 🙂

@marlonrichert marlonrichert self-assigned this Oct 25, 2022
@marlonrichert marlonrichert removed their assignment Nov 15, 2022
marlonrichert added a commit that referenced this issue Feb 23, 2023
marlonrichert added a commit that referenced this issue Feb 27, 2023
marlonrichert added a commit that referenced this issue Mar 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant